From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B988335973; Tue, 8 Apr 2025 11:39:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744112345; cv=none; b=TlqyT0L6AGlasjFn68aWVYarfOC5rNaGO3n3Jyh33RVV2yOCJszPB2j+FREijUjNFUQtSYCW0NpBmGVBLPje2uw4AD7BuJ2NdRA6wiyRBV0HLGRCLuoYwwAz7Qy/4uadG4k3GItLPk/0Th81hXfx81+OafiByQimgQn49MzYZTg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744112345; c=relaxed/simple; bh=s3sofGR6TJyfSvo1FnTFnW1nxjK6Si7opQJlAv3w+nc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=gxmj7QgySUULZ8KKtkTsFYkbaF/3+EDIc9bUoYV/jMpFkBm9FocWlUhRgJFgQK/idhyh0RIe8txnviq+tcuuSs2eGy9YMjqTLV9E/5vwyPf9LPLbY/mL/tdGNP9RsAlTW2q3JAvddCGFLp0wqYU/7YDQkv36USEjoW7B3l1QTHo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=ZEzqOZ0M; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="ZEzqOZ0M" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4511CC4CEE5; Tue, 8 Apr 2025 11:39:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1744112345; bh=s3sofGR6TJyfSvo1FnTFnW1nxjK6Si7opQJlAv3w+nc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ZEzqOZ0MkmAZWSxcfnN4d8+O7UHcSbzGLplz5KR3jmNgGBQ+s/MCxUor5JdHIvFYk GhVSoqsMTcTqR7UXXj5Pw4WRibbd6gVLAs9OShkylVBeLJvzvd65oQmspVhNUeAltE Hg5686Mjzk7scW33ztZehZ0PwhtT0BXLH2UX4H5k= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Zhang Lixu , Srinivas Pandruvada , Jiri Kosina , Sasha Levin Subject: [PATCH 5.15 033/279] HID: intel-ish-hid: fix the length of MNG_SYNC_FW_CLOCK in doorbell Date: Tue, 8 Apr 2025 12:46:56 +0200 Message-ID: <20250408104827.275257511@linuxfoundation.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250408104826.319283234@linuxfoundation.org> References: <20250408104826.319283234@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Zhang Lixu [ Upstream commit 4b54ae69197b9f416baa0fceadff7e89075f8454 ] The timestamps in the Firmware log and HID sensor samples are incorrect. They show 1970-01-01 because the current IPC driver only uses the first 8 bytes of bootup time when synchronizing time with the firmware. The firmware converts the bootup time to UTC time, which results in the display of 1970-01-01. In write_ipc_from_queue(), when sending the MNG_SYNC_FW_CLOCK message, the clock is updated according to the definition of ipc_time_update_msg. However, in _ish_sync_fw_clock(), the message length is specified as the size of uint64_t when building the doorbell. As a result, the firmware only receives the first 8 bytes of struct ipc_time_update_msg. This patch corrects the length in the doorbell to ensure the entire ipc_time_update_msg is sent, fixing the timestamp issue. Signed-off-by: Zhang Lixu Acked-by: Srinivas Pandruvada Signed-off-by: Jiri Kosina Signed-off-by: Sasha Levin --- drivers/hid/intel-ish-hid/ipc/ipc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/hid/intel-ish-hid/ipc/ipc.c b/drivers/hid/intel-ish-hid/ipc/ipc.c index ba45605fc6b52..a48f7cd514b0f 100644 --- a/drivers/hid/intel-ish-hid/ipc/ipc.c +++ b/drivers/hid/intel-ish-hid/ipc/ipc.c @@ -577,14 +577,14 @@ static void fw_reset_work_fn(struct work_struct *unused) static void _ish_sync_fw_clock(struct ishtp_device *dev) { static unsigned long prev_sync; - uint64_t usec; + struct ipc_time_update_msg time = {}; if (prev_sync && jiffies - prev_sync < 20 * HZ) return; prev_sync = jiffies; - usec = ktime_to_us(ktime_get_boottime()); - ipc_send_mng_msg(dev, MNG_SYNC_FW_CLOCK, &usec, sizeof(uint64_t)); + /* The fields of time would be updated while sending message */ + ipc_send_mng_msg(dev, MNG_SYNC_FW_CLOCK, &time, sizeof(time)); } /** -- 2.39.5