From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 228CE227EBD; Tue, 8 Apr 2025 11:43:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744112624; cv=none; b=p+HnbLgUr6vjn8lhiEfa8Phriu26nNOiIUGaiMOcMaIslaVHLTVVG3aWVoHE2snt2X0DszN8vS9PwZBhH8srsUOPorIacwmwAd47JyZCb+rF2eGZVrwprM1T6ZzUNSVnxttKvg+Qd746HGT+lXjBZT8p8knjqWGv5eeBHkAp6wk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744112624; c=relaxed/simple; bh=SAnlpREnCpEN7fLoQ4ZqC851Rz1wrU4QTBGgm92Onhg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=pnJGO4DaBbt21/ZJSXYZieq+4xy1A1wSacMT+8gxQCKqlrvjC5icRXRkLEruXY+LU3GwiXphgO32dypajGjvpSqyLRGGMfKGGa5CqC670XFrhKCrSXM+KRUqLGid8ConA9tfM2l4BHFTelTmnjPM8ID40BcKJF0yqUCt/LAUxFo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=JmlZ4MCP; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="JmlZ4MCP" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A6859C4CEE5; Tue, 8 Apr 2025 11:43:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1744112624; bh=SAnlpREnCpEN7fLoQ4ZqC851Rz1wrU4QTBGgm92Onhg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JmlZ4MCPEwjx8VpVlw+c24w6nBeyMuBcoL7RlKf2N1vtHhY/bLcr8J68lvyuljTFn kAbHChcbKlOz6ht21c1ksx5EaqaYFd2xXPgnIA8XJFN3hxbUm+y723Ng7GY0Qm7U7l aYRubf0L7goxSuEi2i2Xi8fmSlDsRdeA0xxuPgo4= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Qiuxu Zhuo , Tony Luck , Gary Wang , Sasha Levin Subject: [PATCH 5.15 138/279] EDAC/ie31200: Fix the error path order of ie31200_init() Date: Tue, 8 Apr 2025 12:48:41 +0200 Message-ID: <20250408104830.066394822@linuxfoundation.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250408104826.319283234@linuxfoundation.org> References: <20250408104826.319283234@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Qiuxu Zhuo [ Upstream commit 231e341036d9988447e3b3345cf741a98139199e ] The error path order of ie31200_init() is incorrect, fix it. Fixes: 709ed1bcef12 ("EDAC/ie31200: Fallback if host bridge device is already initialized") Signed-off-by: Qiuxu Zhuo Signed-off-by: Tony Luck Tested-by: Gary Wang Link: https://lore.kernel.org/r/20250310011411.31685-4-qiuxu.zhuo@intel.com Signed-off-by: Sasha Levin --- drivers/edac/ie31200_edac.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/edac/ie31200_edac.c b/drivers/edac/ie31200_edac.c index ead3646294b68..acb011cfd8c4f 100644 --- a/drivers/edac/ie31200_edac.c +++ b/drivers/edac/ie31200_edac.c @@ -607,7 +607,7 @@ static int __init ie31200_init(void) pci_rc = pci_register_driver(&ie31200_driver); if (pci_rc < 0) - goto fail0; + return pci_rc; if (!mci_pdev) { ie31200_registered = 0; @@ -618,11 +618,13 @@ static int __init ie31200_init(void) if (mci_pdev) break; } + if (!mci_pdev) { edac_dbg(0, "ie31200 pci_get_device fail\n"); pci_rc = -ENODEV; - goto fail1; + goto fail0; } + pci_rc = ie31200_init_one(mci_pdev, &ie31200_pci_tbl[i]); if (pci_rc < 0) { edac_dbg(0, "ie31200 init fail\n"); @@ -630,12 +632,12 @@ static int __init ie31200_init(void) goto fail1; } } - return 0; + return 0; fail1: - pci_unregister_driver(&ie31200_driver); -fail0: pci_dev_put(mci_pdev); +fail0: + pci_unregister_driver(&ie31200_driver); return pci_rc; } -- 2.39.5