From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3E0982690EC; Tue, 8 Apr 2025 11:53:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744113239; cv=none; b=SLBr3djuIQuoIvNzR4ELP6BtpHaGxGRWXieow4COsyJudVKgioMzFoDjLkM4geRJp2zrSdfrqjtLEt6dFzXe6vip0/yYRIULGPvBzscjf5rSGu9I2tezPA6J7c0O7Vk1cBgB3qjP9FkPvTIKWklg/dfdwkUVLW1ZuEG1O8sDHlE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744113239; c=relaxed/simple; bh=rvpgXEo4k86tRpwbJNRkha9HjWFe8cB5xuLLzMO6c/s=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=UktwpBgUZ/7khrXDRUgAi8bQhCwDfTEQ41GVNCbnapT1vVPHjJQMNs01zhh2DaICxOlNNMslNk41MHQR0z24bA5cIZwVFEvmVspiXS+DInPDdJMeM2stSzZXJI1EnEliPHCDWF3hlKs9MacyBJ5F5gYokyrRZ3eVdaqgLRtitzc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=uCAY8VtJ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="uCAY8VtJ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B71B9C4CEE5; Tue, 8 Apr 2025 11:53:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1744113239; bh=rvpgXEo4k86tRpwbJNRkha9HjWFe8cB5xuLLzMO6c/s=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=uCAY8VtJCc2C04dtWOTtD08fNK0IhiaiLXN7eoF9M7XOuoltL+j6ODJSaUIGLfpV3 ObluIYZbqE8uJM1P0OQy0DH00Z5I02wj2T10P8rIKWRY8QmXvCje1B4qVqSYyxCUYE 8Zngn1RGqvcCgLxJlHk9glafy2kmNiaoti4VqkxI= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Prathamesh Shete , Linus Walleij , Sasha Levin Subject: [PATCH 6.6 085/268] pinctrl: tegra: Set SFIO mode to Mux Register Date: Tue, 8 Apr 2025 12:48:16 +0200 Message-ID: <20250408104830.786353475@linuxfoundation.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250408104828.499967190@linuxfoundation.org> References: <20250408104828.499967190@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Prathamesh Shete [ Upstream commit 17013f0acb322e5052ff9b9d0fab0ab5a4bfd828 ] Tegra devices have an 'sfsel' bit field that determines whether a pin operates in SFIO (Special Function I/O) or GPIO mode. Currently, tegra_pinctrl_gpio_disable_free() sets this bit when releasing a GPIO. However, tegra_pinctrl_set_mux() can be called independently in certain code paths where gpio_disable_free() is not invoked. In such cases, failing to set the SFIO mode could lead to incorrect pin configurations, resulting in functional issues for peripherals relying on SFIO. This patch ensures that whenever set_mux() is called, the SFIO mode is correctly set in the Mux Register if the 'sfsel' bit is present. This prevents situations where the pin remains in GPIO mode despite being configured for SFIO use. Fixes: 971dac7123c7 ("pinctrl: add a driver for NVIDIA Tegra") Signed-off-by: Prathamesh Shete Link: https://lore.kernel.org/20250306050542.16335-1-pshete@nvidia.com Signed-off-by: Linus Walleij Signed-off-by: Sasha Levin --- drivers/pinctrl/tegra/pinctrl-tegra.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/pinctrl/tegra/pinctrl-tegra.c b/drivers/pinctrl/tegra/pinctrl-tegra.c index 734c71ef005b8..7c12a3470642c 100644 --- a/drivers/pinctrl/tegra/pinctrl-tegra.c +++ b/drivers/pinctrl/tegra/pinctrl-tegra.c @@ -272,6 +272,9 @@ static int tegra_pinctrl_set_mux(struct pinctrl_dev *pctldev, val = pmx_readl(pmx, g->mux_bank, g->mux_reg); val &= ~(0x3 << g->mux_bit); val |= i << g->mux_bit; + /* Set the SFIO/GPIO selection to SFIO when under pinmux control*/ + if (pmx->soc->sfsel_in_mux) + val |= (1 << g->sfsel_bit); pmx_writel(pmx, val, g->mux_bank, g->mux_reg); return 0; -- 2.39.5