From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 88490265602; Tue, 8 Apr 2025 11:45:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744112745; cv=none; b=S9aWC51wpyCukQZaXdNWGfMLQcu4pMYWK2JF2jUNp/qUZlPhJ+gfq61w1/SlaaBu6w8Ga+nq7wKC5cim/MP37KnJ+C/pczaHSUb94j/oz15gDAwSbcHdUStskCXHLvWvAvIKRhSJ+khp0SVP520jhfgVCVh6teJ1ratdCEWNo8E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744112745; c=relaxed/simple; bh=e9L3E/WEFv+Mr4m/a381G70ZQjFHkaSC5w9tHbNAm7I=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=DQ6GwkUFL9EHqk1eZfg83tsGQHxGtBp0YQJE+ZbboB2i495VF4VZBFA2pjKwvl2lTxBxo2egNQR9F5NXdRbfz+aSOq1ERC8gYMf5Zwb9wsVE6x9o5zLO2E68JAzACTrr15xReu2zR2AiHm1WXiD+s0r6xq78OcbfOgFOtasGmxs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=QoO8QNtv; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="QoO8QNtv" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 17977C4CEE5; Tue, 8 Apr 2025 11:45:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1744112745; bh=e9L3E/WEFv+Mr4m/a381G70ZQjFHkaSC5w9tHbNAm7I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=QoO8QNtv3S8ZNJbWYn78MaqysbPD+8RzEpbH6Y2WBGZCL02n8ljSvsn8o/d8SzrlT onnVx3hlZ8eIcXuonY0YLCj84XTr6vqmZU5rcvCVOWc7lY34dWnU02Dxn9Pf9nhfQB OWxD43T86YT2LMxODnmjCy8zciAeMgRDEpJV/FsQ= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Danila Chernetsov , Helge Deller , Sasha Levin Subject: [PATCH 5.15 165/279] fbdev: sm501fb: Add some geometry checks. Date: Tue, 8 Apr 2025 12:49:08 +0200 Message-ID: <20250408104830.788105806@linuxfoundation.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250408104826.319283234@linuxfoundation.org> References: <20250408104826.319283234@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Danila Chernetsov [ Upstream commit aee50bd88ea5fde1ff4cc021385598f81a65830c ] Added checks for xoffset, yoffset settings. Incorrect settings of these parameters can lead to errors in sm501fb_pan_ functions. Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixes: 5fc404e47bdf ("[PATCH] fb: SM501 framebuffer driver") Signed-off-by: Danila Chernetsov Signed-off-by: Helge Deller Signed-off-by: Sasha Levin --- drivers/video/fbdev/sm501fb.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/video/fbdev/sm501fb.c b/drivers/video/fbdev/sm501fb.c index 6a52eba645596..3c46838651b06 100644 --- a/drivers/video/fbdev/sm501fb.c +++ b/drivers/video/fbdev/sm501fb.c @@ -326,6 +326,13 @@ static int sm501fb_check_var(struct fb_var_screeninfo *var, if (var->xres_virtual > 4096 || var->yres_virtual > 2048) return -EINVAL; + /* geometry sanity checks */ + if (var->xres + var->xoffset > var->xres_virtual) + return -EINVAL; + + if (var->yres + var->yoffset > var->yres_virtual) + return -EINVAL; + /* can cope with 8,16 or 32bpp */ if (var->bits_per_pixel <= 8) -- 2.39.5