From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4771AA94A; Tue, 8 Apr 2025 12:01:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744113685; cv=none; b=qrvgGCcYzTED3pvh0Yd1CcR1Az0w8TI7agNOn/iiRE6S/Q4Olc8Qabu3F8fJ/0086stnT9WkifppTJmDeXxrfQZcbkyVyntzgA147FxtmBzCQ2ekmZHRjreLqvdRNBgFbdYk1R/tihwgfODGWIbPRFV7vdTw10ItzwdxoSkSTFI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744113685; c=relaxed/simple; bh=aKGHyZK7unHFC0Id/PyeYZ1f4/L5vj64hZ3uU/sLgO4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=pFDfJH6mUWrlyrjg6RsRmvKg1vDzt2w0+zwtaKnkrrG0dJ3+gxrDpET7wQuXc17D4nDbL/kLURmwXZi0ZlU+epBWl1q00TCT8agT9FfEpY4Bj5MXnbQvR5o9ex5nAL1DZE0phT6Pazmfa+SrfYyw8cBZLPV1JLHcY8Ilb9lJqbU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=C8EXw/tw; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="C8EXw/tw" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C404DC4CEE5; Tue, 8 Apr 2025 12:01:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1744113685; bh=aKGHyZK7unHFC0Id/PyeYZ1f4/L5vj64hZ3uU/sLgO4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=C8EXw/twJ9yz+BQaSU4SWO6pc0mzyDbXVP+y1IdtEnfNZieN+3XlAqe00NwiJoTK+ oncaKKY92hzV4ZZv2ou7mmhzNDWOEwQ9R9H7sxQAsa8MzHUBUEWsj9xXlIbfvQ5C/1 WR6fR0fr24U2mhuIAOWj4RpKTeVe2+VPGEcVWS2M= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Norbert Szetei , Namjae Jeon , Steve French Subject: [PATCH 6.6 252/268] ksmbd: add bounds check for create lease context Date: Tue, 8 Apr 2025 12:51:03 +0200 Message-ID: <20250408104835.381284634@linuxfoundation.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250408104828.499967190@linuxfoundation.org> References: <20250408104828.499967190@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Norbert Szetei commit bab703ed8472aa9d109c5f8c1863921533363dae upstream. Add missing bounds check for create lease context. Cc: stable@vger.kernel.org Reported-by: Norbert Szetei Tested-by: Norbert Szetei Signed-off-by: Norbert Szetei Signed-off-by: Namjae Jeon Signed-off-by: Steve French Signed-off-by: Greg Kroah-Hartman --- fs/smb/server/oplock.c | 8 ++++++++ 1 file changed, 8 insertions(+) --- a/fs/smb/server/oplock.c +++ b/fs/smb/server/oplock.c @@ -1505,6 +1505,10 @@ struct lease_ctx_info *parse_lease_state if (sizeof(struct lease_context_v2) == le32_to_cpu(cc->DataLength)) { struct create_lease_v2 *lc = (struct create_lease_v2 *)cc; + if (le16_to_cpu(cc->DataOffset) + le32_to_cpu(cc->DataLength) < + sizeof(struct create_lease_v2) - 4) + return NULL; + memcpy(lreq->lease_key, lc->lcontext.LeaseKey, SMB2_LEASE_KEY_SIZE); lreq->req_state = lc->lcontext.LeaseState; lreq->flags = lc->lcontext.LeaseFlags; @@ -1517,6 +1521,10 @@ struct lease_ctx_info *parse_lease_state } else { struct create_lease *lc = (struct create_lease *)cc; + if (le16_to_cpu(cc->DataOffset) + le32_to_cpu(cc->DataLength) < + sizeof(struct create_lease)) + return NULL; + memcpy(lreq->lease_key, lc->lcontext.LeaseKey, SMB2_LEASE_KEY_SIZE); lreq->req_state = lc->lcontext.LeaseState; lreq->flags = lc->lcontext.LeaseFlags;