From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A92832698AE; Tue, 8 Apr 2025 12:46:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744116410; cv=none; b=k53tUcuy7yzmWjX4RnWiSZOA/jMabcGIkfyIfgIJO785bs0gFNxrvcTmDlTiPz7EMfU9S4L79j5DNQok5fEq91wF/cRh+BNy8i3CugvtQziguUgD4WyBjhGXO2D+Ob9/26aHydQlIMpXLzaL2LH0qC3CaHKFnWPG+Gr3mWMLE4s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744116410; c=relaxed/simple; bh=/fOxvtsmGx5riNvoEY0LrhTLA+0eajNGzxqSeK3S8Xs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=AzbBfiZI1dEbaOP6Q7A6jHp49yn6r3s/+A0Z13KHQe7FLxrnC/e0bZI63VjxI0S6u+6SywFenRg4VRD3v/sMruWMFzI0stwvLsJTU5wrWdOHdX+rs4hkB+0RI4yY1ooARftTN5+tgJ+F4+VyPz2LVr80A7tpuJIJHR+JKvlUm8Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=lXfjJi4D; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="lXfjJi4D" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C42E4C4CEE5; Tue, 8 Apr 2025 12:46:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1744116410; bh=/fOxvtsmGx5riNvoEY0LrhTLA+0eajNGzxqSeK3S8Xs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lXfjJi4DRS/Ivqby/R2YWDlm4TII9WM5joC/dx/tC87OS4HR+Ot2TInUInYyh2i1s 05CevhlqduwSqb7looU3zuW3Cy64fRKCnu+obY2gISiGJSM3X7R8TF7h6sB+0YatAr FobMPYNT04vb2NuK8r31+tJx1B9h4vwihjRuRcUY= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Markus Elfring , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= , Helge Deller , Sasha Levin Subject: [PATCH 6.12 093/423] fbdev: au1100fb: Move a variable assignment behind a null pointer check Date: Tue, 8 Apr 2025 12:46:59 +0200 Message-ID: <20250408104847.907321515@linuxfoundation.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250408104845.675475678@linuxfoundation.org> References: <20250408104845.675475678@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 6.12-stable review patch. If anyone has any objections, please let me know. ------------------ From: Markus Elfring [ Upstream commit 2df2c0caaecfd869b49e14f2b8df822397c5dd7f ] The address of a data structure member was determined before a corresponding null pointer check in the implementation of the function “au1100fb_setmode”. This issue was detected by using the Coccinelle software. Fixes: 3b495f2bb749 ("Au1100 FB driver uplift for 2.6.") Signed-off-by: Markus Elfring Acked-by: Uwe Kleine-König Signed-off-by: Helge Deller Signed-off-by: Sasha Levin --- drivers/video/fbdev/au1100fb.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/video/fbdev/au1100fb.c b/drivers/video/fbdev/au1100fb.c index 840f221607635..6251a6b07b3a1 100644 --- a/drivers/video/fbdev/au1100fb.c +++ b/drivers/video/fbdev/au1100fb.c @@ -137,13 +137,15 @@ static int au1100fb_fb_blank(int blank_mode, struct fb_info *fbi) */ int au1100fb_setmode(struct au1100fb_device *fbdev) { - struct fb_info *info = &fbdev->info; + struct fb_info *info; u32 words; int index; if (!fbdev) return -EINVAL; + info = &fbdev->info; + /* Update var-dependent FB info */ if (panel_is_active(fbdev->panel) || panel_is_color(fbdev->panel)) { if (info->var.bits_per_pixel <= 8) { -- 2.39.5