From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 60DC726B093; Tue, 8 Apr 2025 12:47:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744116459; cv=none; b=rAA0M6Jz1hwTzp1XmbDEOppbqMfjbfMQ0zRd91EBRuIBfHlAxnBhdYhnerHlc5TgTJr7h3ekCZGuysNr85v2PVPlMlfYo3YLOmve3TxJeGSUT+tT0+HXGYuCYj7W7eqcL80sqbjzuWbKUWhoS918w2D+kCNgebLvnY9ZlQtEmYw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744116459; c=relaxed/simple; bh=jyc4ZwuSVKfwAuU+IYSrb4JCBzIg7L8gP9G9C2csZRw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=f4qCjvIwTgf4WkwxfvBphMokw/uPA56EMNtiderecqsqJgKVGykbg02YWu1CZ8j/HSPiJxd5fXPnUoWgB1l4lQrcyl3MmCDfd4Oo/5YlzSS3MfKesY4KDdlh4uDix1dZT24W5Gux6VTHI4Z6Z5OfWG3KucYfpMAjN7rD8dIt5SU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=xyPcnXqR; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="xyPcnXqR" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A80BEC4CEE5; Tue, 8 Apr 2025 12:47:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1744116459; bh=jyc4ZwuSVKfwAuU+IYSrb4JCBzIg7L8gP9G9C2csZRw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=xyPcnXqRAM629LJBx/RIE1pZPgGS8RtxtfV+oQjobk9I2kbjV/Joq01uz+fBtOnaf dVCxFfSM4xi4Uzo8qdQKP4pzAOPvWDxujyakVhvRE2mrynWodfbZllggH99Q6hQYcg UuiIx6H5FPyBAOyUdZnMNQgwWEicnCLcY2Bv3Zyo= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Artur Weber , Krzysztof Kozlowski , Sebastian Reichel , Sasha Levin Subject: [PATCH 6.12 149/423] power: supply: max77693: Fix wrong conversion of charge input threshold value Date: Tue, 8 Apr 2025 12:47:55 +0200 Message-ID: <20250408104849.202733416@linuxfoundation.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250408104845.675475678@linuxfoundation.org> References: <20250408104845.675475678@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.12-stable review patch. If anyone has any objections, please let me know. ------------------ From: Artur Weber [ Upstream commit 30cc7b0d0e9341d419eb7da15fb5c22406dbe499 ] The charge input threshold voltage register on the MAX77693 PMIC accepts four values: 0x0 for 4.3v, 0x1 for 4.7v, 0x2 for 4.8v and 0x3 for 4.9v. Due to an oversight, the driver calculated the values for 4.7v and above starting from 0x0, rather than from 0x1 ([(4700000 - 4700000) / 100000] gives 0). Add 1 to the calculation to ensure that 4.7v is converted to a register value of 0x1 and that the other two voltages are converted correctly as well. Fixes: 87c2d9067893 ("power: max77693: Add charger driver for Maxim 77693") Signed-off-by: Artur Weber Reviewed-by: Krzysztof Kozlowski Link: https://lore.kernel.org/r/20250316-max77693-charger-input-threshold-fix-v1-1-2b037d0ac722@gmail.com Signed-off-by: Sebastian Reichel Signed-off-by: Sasha Levin --- drivers/power/supply/max77693_charger.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/power/supply/max77693_charger.c b/drivers/power/supply/max77693_charger.c index 4caac142c4285..b32d881111850 100644 --- a/drivers/power/supply/max77693_charger.c +++ b/drivers/power/supply/max77693_charger.c @@ -608,7 +608,7 @@ static int max77693_set_charge_input_threshold_volt(struct max77693_charger *chg case 4700000: case 4800000: case 4900000: - data = (uvolt - 4700000) / 100000; + data = ((uvolt - 4700000) / 100000) + 1; break; default: dev_err(chg->dev, "Wrong value for charge input voltage regulation threshold\n"); -- 2.39.5