From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7CC2F26A0AF; Tue, 8 Apr 2025 12:17:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744114676; cv=none; b=fUsm/6alTPKjyUBJ+Gt4W2nMaSPqGa8u5wDDzg+ScfH+8aNb3z56uiCfAwZLVNsg3Balo4kJBCCShLhhwqA43BzxN4Vr4+g9yXJMoqM0eIveNqEYHaRpB5p2Zs8dsQlUy8dQBUAyyP7tFMdaaBPmmUwuLrrm/2LtsIttADPCGkA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744114676; c=relaxed/simple; bh=XB6T9Gj15MsWYNExr817IiK8yqTgtGpYhbQPq/zoTqA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=gTNFhVuvCdWGREAVy1PBUVUg4vdugigXWVUnrN3S2Ni2fDxm4mxyEvTSQ47Yqi5PCFENOnodzOe5irKF7MlkY+zYXhyG7k8QW6DFkUsRdS6G5nUWlAO72KJ6CrAUZ6oAA65S7bjEe8B1EeJYp1St5BJFTc+x5Jkfx+WVFwyhVgU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=Ep/Z3K+C; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="Ep/Z3K+C" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0E4FEC4CEE5; Tue, 8 Apr 2025 12:17:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1744114676; bh=XB6T9Gj15MsWYNExr817IiK8yqTgtGpYhbQPq/zoTqA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Ep/Z3K+CNvYGguHyLotW/6lG8U+wETsWkceb9OFwPM42lBPQdeBgCP1Mk9vx6wK+n rcrmq9x7s60U4lYPfcrmqG3GjLwAtaZKtbxON/IZ/H5pdVt+KhFseKE36ssGoJ8CVv HwObjsicpq7eKay+DbxpTgZWVZnjmdaunlq63pto= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Wenkai Lin , Chenghai Huang , Herbert Xu , Sasha Levin Subject: [PATCH 6.13 194/499] crypto: hisilicon/sec2 - fix for aead auth key length Date: Tue, 8 Apr 2025 12:46:46 +0200 Message-ID: <20250408104856.023698120@linuxfoundation.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250408104851.256868745@linuxfoundation.org> References: <20250408104851.256868745@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.13-stable review patch. If anyone has any objections, please let me know. ------------------ From: Wenkai Lin [ Upstream commit 1b284ffc30b02808a0de698667cbcf5ce5f9144e ] According to the HMAC RFC, the authentication key can be 0 bytes, and the hardware can handle this scenario. Therefore, remove the incorrect validation for this case. Fixes: 2f072d75d1ab ("crypto: hisilicon - Add aead support on SEC2") Signed-off-by: Wenkai Lin Signed-off-by: Chenghai Huang Signed-off-by: Herbert Xu Signed-off-by: Sasha Levin --- drivers/crypto/hisilicon/sec2/sec_crypto.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/crypto/hisilicon/sec2/sec_crypto.c b/drivers/crypto/hisilicon/sec2/sec_crypto.c index 82827d637492a..8ea5305bc320f 100644 --- a/drivers/crypto/hisilicon/sec2/sec_crypto.c +++ b/drivers/crypto/hisilicon/sec2/sec_crypto.c @@ -1085,11 +1085,6 @@ static int sec_aead_auth_set_key(struct sec_auth_ctx *ctx, struct crypto_shash *hash_tfm = ctx->hash_tfm; int blocksize, digestsize, ret; - if (!keys->authkeylen) { - pr_err("hisi_sec2: aead auth key error!\n"); - return -EINVAL; - } - blocksize = crypto_shash_blocksize(hash_tfm); digestsize = crypto_shash_digestsize(hash_tfm); if (keys->authkeylen > blocksize) { @@ -1101,7 +1096,8 @@ static int sec_aead_auth_set_key(struct sec_auth_ctx *ctx, } ctx->a_key_len = digestsize; } else { - memcpy(ctx->a_key, keys->authkey, keys->authkeylen); + if (keys->authkeylen) + memcpy(ctx->a_key, keys->authkey, keys->authkeylen); ctx->a_key_len = keys->authkeylen; } -- 2.39.5