From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D9DAF26A087; Tue, 8 Apr 2025 12:28:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744115324; cv=none; b=KbUdg8FSd4xTgBwc84PCyoZ0i/VOVA7nmf0rQZEYmTYeo2dJj6Gewv2vypInbh1ICOLyGDFBR0cPd3eqoBT4ZPgxy9kyfsLWCMH4y6u+9NWRGrDLBzs7iKpnkVr1Wo2UvB9bpk7PFxk61BfoMTZ8UVTsLk6pPkG1Z2t4+TugMsk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744115324; c=relaxed/simple; bh=0U5SLMSp005Ncnaby2ZmEqfAhHLNlit/Hn7ODydw8Jk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=NPr182M7d9XLzhz3wNp5raj/HNbmuD19a2gpARj2IBfiva3abd70uQTHUaxUATTIma1aUszKwudZjqXJhIxxPsKiQmekCN/CtRvZOdXET3xL8Dc11vN9t5Ir7aQHd0FJlLPkb0ZQdOFupjfGtYp0EWyyktCXju6xgYqM2rNcjvM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=hCdOMOxR; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="hCdOMOxR" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 42F94C4CEE5; Tue, 8 Apr 2025 12:28:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1744115324; bh=0U5SLMSp005Ncnaby2ZmEqfAhHLNlit/Hn7ODydw8Jk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hCdOMOxRmA8ATf2z7umqVqSyjhYZ+/VAsUNvn0QXpd9zuUcgC2TfoPCNtqtgxca+E mKOpb6igKI/xpAjCtF2O0wNSUDRvArzJaHi31LUqA160NhDorPwab65UgA4SkJot0m 7oSICX+MfI6oF0XiTMKQJIzS0aSvo18MCCitW2Nk= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Ying Lu , Jakub Kicinski Subject: [PATCH 6.13 433/499] usbnet:fix NPE during rx_complete Date: Tue, 8 Apr 2025 12:50:45 +0200 Message-ID: <20250408104902.027412367@linuxfoundation.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250408104851.256868745@linuxfoundation.org> References: <20250408104851.256868745@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 6.13-stable review patch. If anyone has any objections, please let me know. ------------------ From: Ying Lu commit 51de3600093429e3b712e5f091d767babc5dd6df upstream. Missing usbnet_going_away Check in Critical Path. The usb_submit_urb function lacks a usbnet_going_away validation, whereas __usbnet_queue_skb includes this check. This inconsistency creates a race condition where: A URB request may succeed, but the corresponding SKB data fails to be queued. Subsequent processes: (e.g., rx_complete → defer_bh → __skb_unlink(skb, list)) attempt to access skb->next, triggering a NULL pointer dereference (Kernel Panic). Fixes: 04e906839a05 ("usbnet: fix cyclical race on disconnect with work queue") Cc: stable@vger.kernel.org Signed-off-by: Ying Lu Link: https://patch.msgid.link/4c9ef2efaa07eb7f9a5042b74348a67e5a3a7aea.1743584159.git.luying1@xiaomi.com Signed-off-by: Jakub Kicinski Signed-off-by: Greg Kroah-Hartman --- drivers/net/usb/usbnet.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) --- a/drivers/net/usb/usbnet.c +++ b/drivers/net/usb/usbnet.c @@ -530,7 +530,8 @@ static int rx_submit (struct usbnet *dev netif_device_present (dev->net) && test_bit(EVENT_DEV_OPEN, &dev->flags) && !test_bit (EVENT_RX_HALT, &dev->flags) && - !test_bit (EVENT_DEV_ASLEEP, &dev->flags)) { + !test_bit (EVENT_DEV_ASLEEP, &dev->flags) && + !usbnet_going_away(dev)) { switch (retval = usb_submit_urb (urb, GFP_ATOMIC)) { case -EPIPE: usbnet_defer_kevent (dev, EVENT_RX_HALT); @@ -551,8 +552,7 @@ static int rx_submit (struct usbnet *dev tasklet_schedule (&dev->bh); break; case 0: - if (!usbnet_going_away(dev)) - __usbnet_queue_skb(&dev->rxq, skb, rx_start); + __usbnet_queue_skb(&dev->rxq, skb, rx_start); } } else { netif_dbg(dev, ifdown, dev->net, "rx: stopped\n");