From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1D588215066 for ; Tue, 8 Apr 2025 10:08:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744106888; cv=none; b=u+FgcuT+U3iYzEy/blogiDDoLi+Eo+qr5qx4cGjM2isQzRzMRnynVS6IKVuKlGJ/QMXU0uLQuE2A+yg8ztCah+div0Oq3S3nVzsaj87oKYGiwj6kyhRObECcRTAVwQTjtRk956/xRnxAg8+hAt92kzBWRie0NFQnZe3EC5s4/Xc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744106888; c=relaxed/simple; bh=YOItWLnMCjUBf0VnJ3vEwIW83ib1zxQrZDaCyc7biLI=; h=Subject:To:Cc:From:Date:Message-ID:MIME-Version:Content-Type; b=jHu1/q1SO4Sn847M7eWAu83mX39wc1Th0PU8Bmq0q6ITGyKQwvOT4c6kmls2yDEq6yMn3X0tvhgxfeMbddGhMou+Br5VHfDGA2MS++AhjJDlXKUMmFVYmMbwj7M1Pdx+OkUz8Shz8thQzAY+ws4jrxSOD+qbxxPyTpJoMgkZGok= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=ICy2d6FW; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="ICy2d6FW" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3D357C4CEE8; Tue, 8 Apr 2025 10:08:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1744106886; bh=YOItWLnMCjUBf0VnJ3vEwIW83ib1zxQrZDaCyc7biLI=; h=Subject:To:Cc:From:Date:From; b=ICy2d6FWaWujrF3GrFJVeY+kbChEdwwXEubf/rozBfxJvhtUPhfr86MAwED3hf75R YVFcJTP+NrVlJ/jXJRJWHRHJOfhiIGgqKYK7jPZUpljEWYh2abCvCvhOmIncvtzfpu BkI9dbEkRi7bJGEnx5vnC5z+tdiCUEY6DnGL+DSg= Subject: FAILED: patch "[PATCH] media: streamzap: fix race between device disconnection and" failed to apply to 5.10-stable tree To: m.masimov@mt-integration.ru,hverkuil@xs4all.nl,sean@mess.org Cc: From: Date: Tue, 08 Apr 2025 12:06:25 +0200 Message-ID: <2025040825-lankiness-posh-a49b@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit The patch below does not apply to the 5.10-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to . To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-5.10.y git checkout FETCH_HEAD git cherry-pick -x f656cfbc7a293a039d6a0c7100e1c846845148c1 # git commit -s git send-email --to '' --in-reply-to '2025040825-lankiness-posh-a49b@gregkh' --subject-prefix 'PATCH 5.10.y' HEAD^.. Possible dependencies: thanks, greg k-h ------------------ original commit in Linus's tree ------------------ >From f656cfbc7a293a039d6a0c7100e1c846845148c1 Mon Sep 17 00:00:00 2001 From: Murad Masimov Date: Mon, 13 Jan 2025 13:51:30 +0300 Subject: [PATCH] media: streamzap: fix race between device disconnection and urb callback Syzkaller has reported a general protection fault at function ir_raw_event_store_with_filter(). This crash is caused by a NULL pointer dereference of dev->raw pointer, even though it is checked for NULL in the same function, which means there is a race condition. It occurs due to the incorrect order of actions in the streamzap_disconnect() function: rc_unregister_device() is called before usb_kill_urb(). The dev->raw pointer is freed and set to NULL in rc_unregister_device(), and only after that usb_kill_urb() waits for in-progress requests to finish. If rc_unregister_device() is called while streamzap_callback() handler is not finished, this can lead to accessing freed resources. Thus rc_unregister_device() should be called after usb_kill_urb(). Found by Linux Verification Center (linuxtesting.org) with Syzkaller. Fixes: 8e9e60640067 ("V4L/DVB: staging/lirc: port lirc_streamzap to ir-core") Cc: stable@vger.kernel.org Reported-by: syzbot+34008406ee9a31b13c73@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=34008406ee9a31b13c73 Signed-off-by: Murad Masimov Signed-off-by: Sean Young Signed-off-by: Hans Verkuil diff --git a/drivers/media/rc/streamzap.c b/drivers/media/rc/streamzap.c index 9b209e687f25..2ce62fe5d60f 100644 --- a/drivers/media/rc/streamzap.c +++ b/drivers/media/rc/streamzap.c @@ -385,8 +385,8 @@ static void streamzap_disconnect(struct usb_interface *interface) if (!sz) return; - rc_unregister_device(sz->rdev); usb_kill_urb(sz->urb_in); + rc_unregister_device(sz->rdev); usb_free_urb(sz->urb_in); usb_free_coherent(usbdev, sz->buf_in_len, sz->buf_in, sz->dma_in);