From: Sasha Levin <sashal@kernel.org>
To: stable@vger.kernel.org
Cc: cel@kernel.org, Sasha Levin <sashal@kernel.org>
Subject: Re: [PATCH v6.13] nfsd: don't ignore the return code of svc_proc_register()
Date: Sun, 13 Apr 2025 12:46:55 -0400 [thread overview]
Message-ID: <20250412101937-75abba5459cc3892@stable.kernel.org> (raw)
In-Reply-To: <20250411141412.27052-1-cel@kernel.org>
[ Sasha's backport helper bot ]
Hi,
✅ All tests passed successfully. No issues detected.
No action required from the submitter.
The upstream commit SHA1 provided is correct: 930b64ca0c511521f0abdd1d57ce52b2a6e3476b
WARNING: Author mismatch between patch and upstream commit:
Backport author: cel@kernel.org
Commit author: Jeff Layton<jlayton@kernel.org>
Status in newer kernel trees:
6.14.y | Present (different SHA1: 9d9456185fd5)
Note: The patch differs from the upstream commit:
---
1: 930b64ca0c511 ! 1: 23c220e9285a7 nfsd: don't ignore the return code of svc_proc_register()
@@ Metadata
## Commit message ##
nfsd: don't ignore the return code of svc_proc_register()
+ [ Upstream commit 930b64ca0c511521f0abdd1d57ce52b2a6e3476b ]
+
Currently, nfsd_proc_stat_init() ignores the return value of
svc_proc_register(). If the procfile creation fails, then the kernel
will WARN when it tries to remove the entry later.
@@ fs/nfsd/nfsctl.c: static __net_init int nfsd_net_init(struct net *net)
seqlock_init(&nn->writeverf_lock);
- nfsd_proc_stat_init(net);
#if IS_ENABLED(CONFIG_NFS_LOCALIO)
- spin_lock_init(&nn->local_clients_lock);
INIT_LIST_HEAD(&nn->local_clients);
#endif
return 0;
---
Results of testing on various branches:
| Branch | Patch Apply | Build Test |
|---------------------------|-------------|------------|
| stable/linux-6.13.y | Success | Success |
prev parent reply other threads:[~2025-04-13 16:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-11 14:14 [PATCH v6.13] nfsd: don't ignore the return code of svc_proc_register() cel
2025-04-13 16:46 ` Sasha Levin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250412101937-75abba5459cc3892@stable.kernel.org \
--to=sashal@kernel.org \
--cc=cel@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).