From: Sasha Levin <sashal@kernel.org>
To: stable@vger.kernel.org, adrian.larumbe@collabora.com
Cc: Sasha Levin <sashal@kernel.org>
Subject: Re: [PATCH 6.13.y] drm/panthor: Replace sleep locks with spinlocks in fdinfo path
Date: Sun, 13 Apr 2025 12:46:43 -0400 [thread overview]
Message-ID: <20250412124204-54cb006dfd3e0948@stable.kernel.org> (raw)
In-Reply-To: <20250411230808.3648376-1-adrian.larumbe@collabora.com>
[ Sasha's backport helper bot ]
Hi,
Summary of potential issues:
⚠️ Found matching upstream commit but patch is missing proper reference to it
Found matching upstream commit: e379856b428acafb8ed689f31d65814da6447b2e
Status in newer kernel trees:
6.14.y | Present (different SHA1: 446311aa801c)
Note: The patch differs from the upstream commit:
---
1: e379856b428ac ! 1: f19951b3eb02d drm/panthor: Replace sleep locks with spinlocks in fdinfo path
@@ Commit message
Reviewed-by: Steven Price <steven.price@arm.com>
Signed-off-by: Steven Price <steven.price@arm.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20250303190923.1639985-1-adrian.larumbe@collabora.com
+ (cherry picked from commit e379856b428acafb8ed689f31d65814da6447b2e)
## drivers/gpu/drm/panthor/panthor_sched.c ##
@@
@@ drivers/gpu/drm/panthor/panthor_sched.c
#include <linux/delay.h>
#include <linux/dma-mapping.h>
@@ drivers/gpu/drm/panthor/panthor_sched.c: struct panthor_group {
+
+ /** @fdinfo: Per-file total cycle and timestamp values reference. */
+ struct {
+- /** @data: Total sampled values for jobs in queues from this group. */
++ /** @fdinfo.data: Total sampled values for jobs in queues from this group. */
struct panthor_gpu_usage data;
/**
@@ drivers/gpu/drm/panthor/panthor_sched.c: struct panthor_group {
*/
- struct mutex lock;
+ spinlock_t lock;
+ } fdinfo;
- /** @fdinfo.kbo_sizes: Aggregate size of private kernel BO's held by the group. */
- size_t kbo_sizes;
+ /** @state: Group state. */
@@ drivers/gpu/drm/panthor/panthor_sched.c: static void group_release_work(struct work_struct *work)
release_work);
u32 i;
@@ drivers/gpu/drm/panthor/panthor_sched.c: void panthor_fdinfo_gather_group_sample
xa_unlock(&gpool->xa);
}
@@ drivers/gpu/drm/panthor/panthor_sched.c: int panthor_group_create(struct panthor_file *pfile,
+ }
mutex_unlock(&sched->reset.lock);
- add_group_kbo_sizes(group->ptdev, group);
- mutex_init(&group->fdinfo.lock);
+ spin_lock_init(&group->fdinfo.lock);
---
Results of testing on various branches:
| Branch | Patch Apply | Build Test |
|---------------------------|-------------|------------|
| stable/linux-6.13.y | Success | Success |
next prev parent reply other threads:[~2025-04-13 16:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-09 10:37 FAILED: patch "[PATCH] drm/panthor: Replace sleep locks with spinlocks in fdinfo" failed to apply to 6.13-stable tree gregkh
2025-04-11 23:08 ` [PATCH 6.13.y] drm/panthor: Replace sleep locks with spinlocks in fdinfo path Adrián Larumbe
2025-04-13 16:46 ` Sasha Levin [this message]
2025-04-17 14:20 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250412124204-54cb006dfd3e0948@stable.kernel.org \
--to=sashal@kernel.org \
--cc=adrian.larumbe@collabora.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).