stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Missing paravirt backport in 6.12.23
@ 2025-04-12  9:27 Ike Devolder
  2025-04-12 10:12 ` Greg KH
  0 siblings, 1 reply; 2+ messages in thread
From: Ike Devolder @ 2025-04-12  9:27 UTC (permalink / raw)
  To: stable

Hi,

Can I report an issue with 6.12 LTS?

This backport in 6.12.23
[805e3ce5e0e32b31dcecc0774c57c17a1f13cef6][1]
also needs this upstream commit as well
[22cc5ca5de52bbfc36a7d4a55323f91fb4492264][2]

If it is missing and you don't have XEN enabled the build fails:

```
arch/x86/coco/tdx/tdx.c:1080:13: error: no member named 'safe_halt' in 
'struct pv_irq_ops'
  1080 |         pv_ops.irq.safe_halt = tdx_safe_halt;
       |         ~~~~~~~~~~ ^
arch/x86/coco/tdx/tdx.c:1081:13: error: no member named 'halt' in 
'struct pv_irq_ops'
  1081 |         pv_ops.irq.halt = tdx_halt;
       |         ~~~~~~~~~~ ^
2 errors generated.
make[5]: *** [scripts/Makefile.build:229: arch/x86/coco/tdx/tdx.o] Error 1
make[4]: *** [scripts/Makefile.build:478: arch/x86/coco/tdx] Error 2
make[3]: *** [scripts/Makefile.build:478: arch/x86/coco] Error 2
make[2]: *** [scripts/Makefile.build:478: arch/x86] Error 2
```

To make it work I have added the backport of 
[805e3ce5e0e32b31dcecc0774c57c17a1f13cef6][1] as patch in my local build[3].

Best regards,
Ike

[1]: 
https://web.git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=linux-6.12.y&id=805e3ce5e0e32b31dcecc0774c57c17a1f13cef6
[2]: 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=22cc5ca5de52bbfc36a7d4a55323f91fb4492264
[3]: 
https://gitlab.com/herecura/packages/linux-bede-lts/-/blob/0d7e313f13fdae9bde7f79967481f186cc1ba8fd/0003-x86-paravirt-Move-halt-paravirt-calls-under-CONFIG_P.patch

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: Missing paravirt backport in 6.12.23
  2025-04-12  9:27 Missing paravirt backport in 6.12.23 Ike Devolder
@ 2025-04-12 10:12 ` Greg KH
  0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2025-04-12 10:12 UTC (permalink / raw)
  To: Ike Devolder; +Cc: stable

On Sat, Apr 12, 2025 at 11:27:18AM +0200, Ike Devolder wrote:
> Hi,
> 
> Can I report an issue with 6.12 LTS?
> 
> This backport in 6.12.23
> [805e3ce5e0e32b31dcecc0774c57c17a1f13cef6][1]
> also needs this upstream commit as well
> [22cc5ca5de52bbfc36a7d4a55323f91fb4492264][2]
> 
> If it is missing and you don't have XEN enabled the build fails:
> 
> ```
> arch/x86/coco/tdx/tdx.c:1080:13: error: no member named 'safe_halt' in
> 'struct pv_irq_ops'
>  1080 |         pv_ops.irq.safe_halt = tdx_safe_halt;
>       |         ~~~~~~~~~~ ^
> arch/x86/coco/tdx/tdx.c:1081:13: error: no member named 'halt' in 'struct
> pv_irq_ops'
>  1081 |         pv_ops.irq.halt = tdx_halt;
>       |         ~~~~~~~~~~ ^
> 2 errors generated.
> make[5]: *** [scripts/Makefile.build:229: arch/x86/coco/tdx/tdx.o] Error 1
> make[4]: *** [scripts/Makefile.build:478: arch/x86/coco/tdx] Error 2
> make[3]: *** [scripts/Makefile.build:478: arch/x86/coco] Error 2
> make[2]: *** [scripts/Makefile.build:478: arch/x86] Error 2
> ```
> 
> To make it work I have added the backport of
> [805e3ce5e0e32b31dcecc0774c57c17a1f13cef6][1] as patch in my local build[3].

Looks like others also agree, it's been submitted a few days ago:
	https://lore.kernel.org/r/20250408132341.4175633-1-vannapurve@google.com

We'll pick it up in a few days for inclusion in the next round of stable
updates, thanks for the report, I didn't realize it was causing build
errors, which is odd that it didn't show up in all of the testing before
now.

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-04-12 10:14 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-12  9:27 Missing paravirt backport in 6.12.23 Ike Devolder
2025-04-12 10:12 ` Greg KH

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).