From: Greg KH <gregkh@linuxfoundation.org>
To: Wentao Liang <vulab@iscas.ac.cn>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH RESEND] usb: renesas_usbhs: Add error handling for usbhsf_fifo_select()
Date: Mon, 14 Apr 2025 09:38:25 +0200 [thread overview]
Message-ID: <2025041410-module-egotistic-6857@gregkh> (raw)
In-Reply-To: <20250414072501.2259-1-vulab@iscas.ac.cn>
On Mon, Apr 14, 2025 at 03:25:01PM +0800, Wentao Liang wrote:
> In usbhsf_dcp_data_stage_prepare_pop(), the return value of
> usbhsf_fifo_select() needs to be checked. A proper implementation
> can be found in usbhsf_dma_try_pop_with_rx_irq().
>
> Add an error check and jump to PIO pop when FIFO selection fails.
>
> Fixes: 9e74d601de8a ("usb: gadget: renesas_usbhs: add data/status stage handler")
> Cc: stable@vger.kernel.org # v3.2+
> Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
> ---
> drivers/usb/renesas_usbhs/fifo.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
Why is this RESEND? What happened to the first one?
thanks,
greg k-h
next prev parent reply other threads:[~2025-04-14 7:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-14 7:25 [PATCH RESEND] usb: renesas_usbhs: Add error handling for usbhsf_fifo_select() Wentao Liang
2025-04-14 7:38 ` Greg KH [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-04-22 2:38 Wentao Liang
2025-04-25 11:01 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025041410-module-egotistic-6857@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=vulab@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).