From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 29DE12DDCE2; Mon, 14 Apr 2025 13:32:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744637536; cv=none; b=VAXhMj4yiFxcXY0BvKevh6W82wQuvR/q3N4xetg740yXA9fQOq2zaSOPF0+KhLAHit5DtsJK8GUzatZzt5Ur23wSLS/alD5HWRn3KnpR5mvQIazzi4udJW2O6jCD/ug4jWky9sEKWS/y1v0wEyu/giBPnr0fFXApqOlh9ixOIrU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744637536; c=relaxed/simple; bh=r5wJNDyotkdmjCXgJusaSbg9HC9NT/c210FefNHFkL4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=JGzjYJ+QKa26mF9j7dpF2M+/AYU30b72Ga4qpcs5O25aY5I+tnrGFyFXxibQ2x26h4cM9QWD025KllRF2BMAofPdSWs/miVEFPpawAS5VmDFT7xxlcPyDxBKMdiH0xuS0I8mFpgA9rxDK6prNnIAw3hBONJj+TtHRT7/YSax9gQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=lkZ2chaM; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="lkZ2chaM" Received: by smtp.kernel.org (Postfix) with ESMTPSA id DB158C4AF09; Mon, 14 Apr 2025 13:32:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1744637536; bh=r5wJNDyotkdmjCXgJusaSbg9HC9NT/c210FefNHFkL4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lkZ2chaM/9mMm8NCKP1qJs3vPug56yG62FZF01JiyUh+nCmufFmHMYnUlaA6Tu0Za AeZMN5XqBDjNxdpLabJ3IUY5zCeRP7A45c+cj3f/c7W7xAJA/hAq7yqQsUlgA9EuFF Qk8BtkM51etBnPJrOG0eXVWdw8HfnhMPYpN6LbJfpc8d9LsApVG79ku/Ry343r1N0G yf1Imq823sOHWypcIFKGnwdIFjmdEKj3jB2mL4bUNNLq4TFlLow2PWWpGn0fAK3dV4 neFumutIq975XvIB++HiDEHAr8Y5FkfrSRzYdMcz6fchFZVH5fz8RgDB6pN1/SRfGE 9wUPjcmkL7Sag== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Qiuxu Zhuo , Yi Lai , Shuah Khan , Sasha Levin , shuah@kernel.org, linux-kselftest@vger.kernel.org Subject: [PATCH AUTOSEL 5.10 08/11] selftests/mincore: Allow read-ahead pages to reach the end of the file Date: Mon, 14 Apr 2025 09:31:55 -0400 Message-Id: <20250414133158.681045-8-sashal@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250414133158.681045-1-sashal@kernel.org> References: <20250414133158.681045-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 5.10.236 Content-Transfer-Encoding: 8bit From: Qiuxu Zhuo [ Upstream commit 197c1eaa7ba633a482ed7588eea6fd4aa57e08d4 ] When running the mincore_selftest on a system with an XFS file system, it failed the "check_file_mmap" test case due to the read-ahead pages reaching the end of the file. The failure log is as below: RUN global.check_file_mmap ... mincore_selftest.c:264:check_file_mmap:Expected i (1024) < vec_size (1024) mincore_selftest.c:265:check_file_mmap:Read-ahead pages reached the end of the file check_file_mmap: Test failed FAIL global.check_file_mmap This is because the read-ahead window size of the XFS file system on this machine is 4 MB, which is larger than the size from the #PF address to the end of the file. As a result, all the pages for this file are populated. blockdev --getra /dev/nvme0n1p5 8192 blockdev --getbsz /dev/nvme0n1p5 512 This issue can be fixed by extending the current FILE_SIZE 4MB to a larger number, but it will still fail if the read-ahead window size of the file system is larger enough. Additionally, in the real world, read-ahead pages reaching the end of the file can happen and is an expected behavior. Therefore, allowing read-ahead pages to reach the end of the file is a better choice for the "check_file_mmap" test case. Link: https://lore.kernel.org/r/20250311080940.21413-1-qiuxu.zhuo@intel.com Reported-by: Yi Lai Signed-off-by: Qiuxu Zhuo Signed-off-by: Shuah Khan Signed-off-by: Sasha Levin --- tools/testing/selftests/mincore/mincore_selftest.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/tools/testing/selftests/mincore/mincore_selftest.c b/tools/testing/selftests/mincore/mincore_selftest.c index 2cf6f2f277ab8..31820435825b1 100644 --- a/tools/testing/selftests/mincore/mincore_selftest.c +++ b/tools/testing/selftests/mincore/mincore_selftest.c @@ -262,9 +262,6 @@ TEST(check_file_mmap) TH_LOG("No read-ahead pages found in memory"); } - EXPECT_LT(i, vec_size) { - TH_LOG("Read-ahead pages reached the end of the file"); - } /* * End of the readahead window. The rest of the pages shouldn't * be in memory. -- 2.39.5