From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D6DBB22D7BC for ; Wed, 16 Apr 2025 08:42:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744792928; cv=none; b=Wr/tqENJTwCJu/2devWK9e37w116MU30BFP1QWMZKkI95H65aBXzWH9ENqlac3aWMbGI87P43qr/u/uuqp0GDlnKk9Ruvk+aqRZzS8SNPiaEYMdzem/iVusvqMM2gTbyTPk7I83aLunl5M/tImUCShKmE/liBTSZFNrT27YrvCs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744792928; c=relaxed/simple; bh=U9E9v/dKdU1m/7V980lLWCVL8KDXiQ6OeP8e6q61OqI=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=ERMzoKkzT+hVvbvGYQuVlBNPGoEKP0WjBtIIZCtnoHbST0foXXwbsQXMkTBcsh/9gBI5OXILJpLjpMl+exAcXapWisp+YwPlWKrs3uzwsOzZdxK2qtmSM4bkq+1fXuR6p4QoXI/oRhrPw00C9JQB8bPPVtxMUVW9z0ZTq0+6q6s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=calm0h0p; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=ulET7mtr; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=UqByA9vq; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=SSQ3Yofc; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="calm0h0p"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="ulET7mtr"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="UqByA9vq"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="SSQ3Yofc" Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 03E132115E; Wed, 16 Apr 2025 08:42:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1744792925; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=4/an8PTPTXnpDWJ4pqiRdLbas9K7aIHlPGUsR84ZNDg=; b=calm0h0pYW6x+p3G+msmBUDRw+9sdVTNO3S9Lis8hLDfPLFhC3rtZj2pVIFyvJGbbF9c4C m0kQQX/AdRajvcj+nyB31rKpdWql2P26yK6H4oJ2mikdYxtzNAvj4ecAYg8QLsK/6sQ+XF Toh435ayeoM83vsZ3YZyGbKJyB4IhAk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1744792925; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=4/an8PTPTXnpDWJ4pqiRdLbas9K7aIHlPGUsR84ZNDg=; b=ulET7mtrbxqoqQZnsWVGIKg+3ZpRTzwuxhsM8m9AgCRF65NyqHESRWATqECDyXQTcYRFRm nRT3C+cCy2uZRfCQ== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=UqByA9vq; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=SSQ3Yofc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1744792924; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=4/an8PTPTXnpDWJ4pqiRdLbas9K7aIHlPGUsR84ZNDg=; b=UqByA9vqaZy9cmpUc7OGhpbtEuVduKvdttFFa3rOpySpFqb3/hfEJrEvMbeE+PdkPpqyXY HUJO5AxZbUIh29TZ9EJlRLimUKoK2cUYg0hzs9lifhlXapnFjYewv90SNjM8tOkQQaFDe3 PCo1u8NbEQBmBdJ9+pjZ1ZFLwLIQxkk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1744792924; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=4/an8PTPTXnpDWJ4pqiRdLbas9K7aIHlPGUsR84ZNDg=; b=SSQ3YofcPa/yVBEMWoihjmdduwjAjS16b+nvOHCMIXJzRbGoIKM1m2p8kMEsvOG+S4ZymB R2M84ceHacWwP4Bg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id C22FC139A1; Wed, 16 Apr 2025 08:42:03 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 6h8eLltt/2eiYwAAD6G6ig (envelope-from ); Wed, 16 Apr 2025 08:42:03 +0000 From: Thomas Zimmermann To: airlied@redhat.com, jfalempe@redhat.com, wakko@animx.eu.org Cc: dri-devel@lists.freedesktop.org, Thomas Zimmermann , =?UTF-8?q?=D0=A1=D0=B5=D1=80=D0=B3=D0=B5=D0=B9?= , stable@vger.kernel.org Subject: [PATCH] drm/mgag200: Fix value in register Date: Wed, 16 Apr 2025 10:38:05 +0200 Message-ID: <20250416083847.51764-1-tzimmermann@suse.de> X-Mailer: git-send-email 2.49.0 Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 03E132115E X-Spam-Level: X-Spamd-Result: default: False [-3.51 / 50.00]; BAYES_HAM(-3.00)[100.00%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_ALL(0.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; RCPT_COUNT_SEVEN(0.00)[7]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_HAS_DN(0.00)[]; FREEMAIL_CC(0.00)[lists.freedesktop.org,suse.de,gmail.com,vger.kernel.org]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DKIM_TRACE(0.00)[suse.de:+] X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Rspamd-Action: no action X-Spam-Score: -3.51 X-Spam-Flag: NO Fix an off-by-one error when setting the vblanking start in . Commit d6460bd52c27 ("drm/mgag200: Add dedicated variables for blanking fields") switched the value from crtc_vdisplay to crtc_vblank_start, which DRM helpers copy from the former. The commit missed to subtract one though. Reported-by: Wakko Warner Closes: https://lore.kernel.org/dri-devel/CAMwc25rKPKooaSp85zDq2eh-9q4UPZD=RqSDBRp1fAagDnmRmA@mail.gmail.com/ Reported-by: Сергей Closes: https://lore.kernel.org/all/5b193b75-40b1-4342-a16a-ae9fc62f245a@gmail.com/ Closes: https://bbs.archlinux.org/viewtopic.php?id=303819 Signed-off-by: Thomas Zimmermann Fixes: d6460bd52c27 ("drm/mgag200: Add dedicated variables for blanking fields") Cc: Thomas Zimmermann Cc: Jocelyn Falempe Cc: Dave Airlie Cc: dri-devel@lists.freedesktop.org Cc: # v6.12+ --- drivers/gpu/drm/mgag200/mgag200_mode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/mgag200/mgag200_mode.c b/drivers/gpu/drm/mgag200/mgag200_mode.c index fb71658c3117..6067d08aeee3 100644 --- a/drivers/gpu/drm/mgag200/mgag200_mode.c +++ b/drivers/gpu/drm/mgag200/mgag200_mode.c @@ -223,7 +223,7 @@ void mgag200_set_mode_regs(struct mga_device *mdev, const struct drm_display_mod vsyncstr = mode->crtc_vsync_start - 1; vsyncend = mode->crtc_vsync_end - 1; vtotal = mode->crtc_vtotal - 2; - vblkstr = mode->crtc_vblank_start; + vblkstr = mode->crtc_vblank_start - 1; vblkend = vtotal + 1; linecomp = vdispend; -- 2.49.0