From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C8258185B67 for ; Thu, 17 Apr 2025 11:24:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744889058; cv=none; b=rbRKWkT0fWQjCVPv+XFhlt5hLkNjAZI+Va5cNjumByB3O1aR5dpnbzvhmQFLjakyZZERRWZX7TC0YCit/qHxjVDABmFH5PhcvRw+NfQg25kmnjKchVq1t6y00dmTtzM7a3yfmhsBT8PhIfkt8po2+euC6+xW5ZPciiHz0OC5oo4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744889058; c=relaxed/simple; bh=2cP1Kgd8kC7SvB/6yzfBLUb6fisOWYFCHcAkhh6Xwkc=; h=Subject:To:Cc:From:Date:Message-ID:MIME-Version:Content-Type; b=VeYXwnt6frHmUyJul557bbtMATBjDjMDfARieVqjLYShY/Ot3UbV0a52UOXrdb1JveRsu0O2rfpu0MFTfQu/JAk3pazTEyUGDx4msjQJ6EfdiR8PIt71y3sm6c/++tyzws23d5LYznnoVkViTQKmUXq6f/mgvLFHU5vZ5VhD9EE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=DxK6I/B7; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="DxK6I/B7" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 35135C4CEE4; Thu, 17 Apr 2025 11:24:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1744889058; bh=2cP1Kgd8kC7SvB/6yzfBLUb6fisOWYFCHcAkhh6Xwkc=; h=Subject:To:Cc:From:Date:From; b=DxK6I/B7Cv3Kl02Uw8onqfrr8Cj7DYYjsqIEfXX10XJsCXCAyMpfUH97+tk1j/bEC PYZjBcOfkCw036PbVgJudg9hRvwzFwpc1usL7vLbzfg4YFoOgpf4d0eqxU1y89RlDF ZPL2z9x6nxa1We7iS6xWlGlUVn9UJZrRAX6dXciQ= Subject: FAILED: patch "[PATCH] iio: adc: ad7768-1: Fix conversion result sign" failed to apply to 5.4-stable tree To: sergiu.cuciurean@analog.com,Jonathan.Cameron@huawei.com,Jonathan.Santos@analog.com,Stable@vger.kernel.org,dlechner@baylibre.com,marcelo.schmitt@analog.com Cc: From: Date: Thu, 17 Apr 2025 13:06:00 +0200 Message-ID: <2025041700-greyhound-yogurt-8e1f@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit The patch below does not apply to the 5.4-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to . To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-5.4.y git checkout FETCH_HEAD git cherry-pick -x 8236644f5ecb180e80ad92d691c22bc509b747bb # git commit -s git send-email --to '' --in-reply-to '2025041700-greyhound-yogurt-8e1f@gregkh' --subject-prefix 'PATCH 5.4.y' HEAD^.. Possible dependencies: thanks, greg k-h ------------------ original commit in Linus's tree ------------------ >From 8236644f5ecb180e80ad92d691c22bc509b747bb Mon Sep 17 00:00:00 2001 From: Sergiu Cuciurean Date: Thu, 6 Mar 2025 18:00:29 -0300 Subject: [PATCH] iio: adc: ad7768-1: Fix conversion result sign The ad7768-1 ADC output code is two's complement, meaning that the voltage conversion result is a signed value.. Since the value is a 24 bit one, stored in a 32 bit variable, the sign should be extended in order to get the correct representation. Also the channel description has been updated to signed representation, to match the ADC specifications. Fixes: a5f8c7da3dbe ("iio: adc: Add AD7768-1 ADC basic support") Reviewed-by: David Lechner Reviewed-by: Marcelo Schmitt Signed-off-by: Sergiu Cuciurean Signed-off-by: Jonathan Santos Cc: Link: https://patch.msgid.link/505994d3b71c2aa38ba714d909a68e021f12124c.1741268122.git.Jonathan.Santos@analog.com Signed-off-by: Jonathan Cameron diff --git a/drivers/iio/adc/ad7768-1.c b/drivers/iio/adc/ad7768-1.c index ea829c51e80b..09e7cccfd51c 100644 --- a/drivers/iio/adc/ad7768-1.c +++ b/drivers/iio/adc/ad7768-1.c @@ -142,7 +142,7 @@ static const struct iio_chan_spec ad7768_channels[] = { .channel = 0, .scan_index = 0, .scan_type = { - .sign = 'u', + .sign = 's', .realbits = 24, .storagebits = 32, .shift = 8, @@ -373,7 +373,7 @@ static int ad7768_read_raw(struct iio_dev *indio_dev, iio_device_release_direct(indio_dev); if (ret < 0) return ret; - *val = ret; + *val = sign_extend32(ret, chan->scan_type.realbits - 1); return IIO_VAL_INT;