From: Greg KH <gregkh@linuxfoundation.org>
To: "Adrián Larumbe" <adrian.larumbe@collabora.com>
Cc: stable@vger.kernel.org, Liviu Dudau <liviu.dudau@arm.com>,
Boris Brezillon <boris.brezillon@collabora.com>,
Steven Price <steven.price@arm.com>
Subject: Re: [PATCH 6.13.y] drm/panthor: Replace sleep locks with spinlocks in fdinfo path
Date: Thu, 17 Apr 2025 16:20:14 +0200 [thread overview]
Message-ID: <2025041703-endearing-zestfully-e20f@gregkh> (raw)
In-Reply-To: <20250411230808.3648376-1-adrian.larumbe@collabora.com>
On Sat, Apr 12, 2025 at 12:08:03AM +0100, Adrián Larumbe wrote:
> Commit 0590c94c3596 ("drm/panthor: Fix race condition when gathering fdinfo
> group samples") introduced an xarray lock to deal with potential
> use-after-free errors when accessing groups fdinfo figures. However, this
> toggles the kernel's atomic context status, so the next nested mutex lock
> will raise a warning when the kernel is compiled with mutex debug options:
>
> CONFIG_DEBUG_RT_MUTEXES=y
> CONFIG_DEBUG_MUTEXES=y
>
> Replace Panthor's group fdinfo data mutex with a guarded spinlock.
>
> Signed-off-by: Adrián Larumbe <adrian.larumbe@collabora.com>
> Fixes: 0590c94c3596 ("drm/panthor: Fix race condition when gathering fdinfo group samples")
> Reviewed-by: Liviu Dudau <liviu.dudau@arm.com>
> Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
> Reviewed-by: Steven Price <steven.price@arm.com>
> Signed-off-by: Steven Price <steven.price@arm.com>
> Link: https://patchwork.freedesktop.org/patch/msgid/20250303190923.1639985-1-adrian.larumbe@collabora.com
> (cherry picked from commit e379856b428acafb8ed689f31d65814da6447b2e)
> ---
> drivers/gpu/drm/panthor/panthor_sched.c | 28 ++++++++++++-------------
> 1 file changed, 13 insertions(+), 15 deletions(-)
Does not apply at all, did something get corrupted?
prev parent reply other threads:[~2025-04-17 14:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-09 10:37 FAILED: patch "[PATCH] drm/panthor: Replace sleep locks with spinlocks in fdinfo" failed to apply to 6.13-stable tree gregkh
2025-04-11 23:08 ` [PATCH 6.13.y] drm/panthor: Replace sleep locks with spinlocks in fdinfo path Adrián Larumbe
2025-04-13 16:46 ` Sasha Levin
2025-04-17 14:20 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025041703-endearing-zestfully-e20f@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=adrian.larumbe@collabora.com \
--cc=boris.brezillon@collabora.com \
--cc=liviu.dudau@arm.com \
--cc=stable@vger.kernel.org \
--cc=steven.price@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).