From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DC9D51DB148; Thu, 17 Apr 2025 18:47:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744915659; cv=none; b=s1Wy1geORih1NQ3EvYtbNKSl7e5eQuWyqSg77F7fURHv5zFWe3uALrjkuRZrqYheuRWh5eDMiHg9lY2733Sn2/OVqR/uIVkAGiqzI5z4nV+h7gZdwA9fKTohVhvYSzxxCIhXtAyLg8qfjAX5mO5BerMTCJVgxW52/gPUzy9glPg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744915659; c=relaxed/simple; bh=IqCnwFhTp7SKAjiEosVkjkqRDkvsRAeKD6d+66Eo10U=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Fzr2vergxB68Sl7WbsxgZxHEICOmEgfhA05Y+OSLbouHh7gQVh3IXYHfN24prz7xYoe7AR29EvZNPB0UDHDFX1bf/odfL4N0TR5ZBSsxmA9375xK1pvHj0tnxSDK/qeW+mregopix580TNPQ/vIunWFq+aVodmzj78FD3rrS+lU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=IUTESaZO; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="IUTESaZO" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4E0C4C4CEE4; Thu, 17 Apr 2025 18:47:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1744915658; bh=IqCnwFhTp7SKAjiEosVkjkqRDkvsRAeKD6d+66Eo10U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=IUTESaZOdBhxDxxAVHxiEHklAFnhjvM2zfBwqoS007OwX7+6ucum5NTe8FlFU5kmN uyaKiyLMz59MYM0x7WrvNGABl8gcmk/50lg8EUICRDx2nGfseD+YedCx/g5ICm+dhb miiIu4I7jCpcamBhd522ppaoQa62MOleYVCfxBNA= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Yuan Can , Ricardo Ribalda , Hans Verkuil Subject: [PATCH 6.12 199/393] media: siano: Fix error handling in smsdvb_module_init() Date: Thu, 17 Apr 2025 19:50:08 +0200 Message-ID: <20250417175115.592383621@linuxfoundation.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250417175107.546547190@linuxfoundation.org> References: <20250417175107.546547190@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.12-stable review patch. If anyone has any objections, please let me know. ------------------ From: Yuan Can commit 734ac57e47b3bdd140a1119e2c4e8e6f8ef8b33d upstream. The smsdvb_module_init() returns without checking the retval from smscore_register_hotplug(). If the smscore_register_hotplug() failed, the module failed to install, leaving the smsdvb_debugfs not unregistered. Fixes: 3f6b87cff66b ("[media] siano: allow showing the complete statistics via debugfs") Cc: stable@vger.kernel.org Signed-off-by: Yuan Can Acked-by: Ricardo Ribalda Signed-off-by: Hans Verkuil Signed-off-by: Greg Kroah-Hartman --- drivers/media/common/siano/smsdvb-main.c | 2 ++ 1 file changed, 2 insertions(+) --- a/drivers/media/common/siano/smsdvb-main.c +++ b/drivers/media/common/siano/smsdvb-main.c @@ -1243,6 +1243,8 @@ static int __init smsdvb_module_init(voi smsdvb_debugfs_register(); rc = smscore_register_hotplug(smsdvb_hotplug); + if (rc) + smsdvb_debugfs_unregister(); pr_debug("\n");