From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 470821B3934; Thu, 17 Apr 2025 18:57:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744916225; cv=none; b=p0WkAWLp3Q7sP9ECBu0XmBHng6anJBV1yjBiOtQynQOEhGWs4NHXo2X4PwGx1KnOiwEkZeWmP3kJ9G5RIMrOINLdVCn/OxJWXFHo1LXAeeV+JNmKBQvYL2XORqqnRY+K6n/uyuVb4FdxeecQuLl0F+9zMek3DIylgU47LMj+RZc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744916225; c=relaxed/simple; bh=24QA61umcGJQKr33IAd2eAhByn7nIJsZLR0PSmo2v7U=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=iTPLHSWM7S/dIIzgQt13n3jup7ew9wcdr86JuEFUDjRLZgomHVPApoLgSjPXI1f3uCQ6+ddbvSmmfNr/B4jVaBLdXpR393Sk1tRm6rC0gAaQ+bAcsfduEHOAYIz+dTqWcmPqVCHt9FylBpWeDKauGqaHKEXyGBAjZ7dF/GrS5eA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=jX7tGVno; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="jX7tGVno" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 933FFC4CEE4; Thu, 17 Apr 2025 18:57:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1744916225; bh=24QA61umcGJQKr33IAd2eAhByn7nIJsZLR0PSmo2v7U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=jX7tGVnoFEYQcTZEM/qFcBeAozJhDTJ4oIHqjeuDOygfh8UGStg6x+hRlryOhcktJ 2ag6s9jAFZqUsnPYy8I+jN1+fgBoW4uV3U2jViZTxF3O/5dkhiPURJRXZkVasNZVV7 1nzEFVpStfqohUwkKFOJYGLuBGscRbhjVlAMBXJs= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Fedor Pchelkin , Dave Jiang , Jon Mason Subject: [PATCH 6.12 356/393] ntb: use 64-bit arithmetic for the MSI doorbell mask Date: Thu, 17 Apr 2025 19:52:45 +0200 Message-ID: <20250417175121.916921954@linuxfoundation.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250417175107.546547190@linuxfoundation.org> References: <20250417175107.546547190@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.12-stable review patch. If anyone has any objections, please let me know. ------------------ From: Fedor Pchelkin commit fd5625fc86922f36bedee5846fefd647b7e72751 upstream. msi_db_mask is of type 'u64', still the standard 'int' arithmetic is performed to compute its value. While most of the ntb_hw drivers actually don't utilize the higher 32 bits of the doorbell mask now, this may be the case for Switchtec - see switchtec_ntb_init_db(). Found by Linux Verification Center (linuxtesting.org) with SVACE static analysis tool. Fixes: 2b0569b3b7e6 ("NTB: Add MSI interrupt support to ntb_transport") Cc: stable@vger.kernel.org Signed-off-by: Fedor Pchelkin Reviewed-by: Dave Jiang Signed-off-by: Jon Mason Signed-off-by: Greg Kroah-Hartman --- drivers/ntb/ntb_transport.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/ntb/ntb_transport.c +++ b/drivers/ntb/ntb_transport.c @@ -1353,7 +1353,7 @@ static int ntb_transport_probe(struct nt qp_count = ilog2(qp_bitmap); if (nt->use_msi) { qp_count -= 1; - nt->msi_db_mask = 1 << qp_count; + nt->msi_db_mask = BIT_ULL(qp_count); ntb_db_clear_mask(ndev, nt->msi_db_mask); }