From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1496223C8C6 for ; Thu, 17 Apr 2025 11:24:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744889079; cv=none; b=j8WBqUUF2r2+EPUpZ+nQoKQnudUdwra3htN2BuQdFCVIMm0ERolENl3hpw28huFV2J1POF2TiqyMRbtB6RnlT6oVfULFbeh7wzSjt6dysa1dPosfpbcpVWIxe3xC5gmOoySuBr8Ok3SeTeJhCZmQTJYzXeY3OJkGjQvvIUU6tjs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744889079; c=relaxed/simple; bh=X4RJ/qIDKry1x59zHMmUrwdPzfb+KK5yunwoTVWfMeI=; h=Subject:To:Cc:From:Date:Message-ID:MIME-Version:Content-Type; b=a5lTeIa2IGVmFqCXoapHx/MhdLswj1ueXEkb6SqyYM1c20tSkFNp0wbwasiQUXvq0xIRlZww+XysBDGetTOU0QTwoi1sYwhTl6NE5tJOb64Tu1u6CUe0kd+NitckRDmeYVY+Bd3Fm+vtGLwmb68z8lBpNRPN11SPzFRn2ItyHJQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=jUl/aFIz; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="jUl/aFIz" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 469CDC4CEEA; Thu, 17 Apr 2025 11:24:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1744889079; bh=X4RJ/qIDKry1x59zHMmUrwdPzfb+KK5yunwoTVWfMeI=; h=Subject:To:Cc:From:Date:From; b=jUl/aFIzpm4udzHFrM+ZZQ05N1L/Pp3wIFkvqxdUij6qmUM2Db2yohzwLH9Uxlz72 GqXQIKOwAjgI1MWLM+OxLo/GtMKOzzq0gWbZJV80WLxqkSFNSzfoQhUUoXV/paUR7Q w8WgeZ2kXuiyMK0pfMMtMtFeqN8GKIf2GcTk2xng= Subject: FAILED: patch "[PATCH] backlight: led_bl: Hold led_access lock when calling" failed to apply to 5.10-stable tree To: herve.codina@bootlin.com,lee@kernel.org Cc: From: Date: Thu, 17 Apr 2025 13:12:44 +0200 Message-ID: <2025041744-widely-hypnosis-3013@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit The patch below does not apply to the 5.10-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to . To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-5.10.y git checkout FETCH_HEAD git cherry-pick -x 276822a00db3c1061382b41e72cafc09d6a0ec30 # git commit -s git send-email --to '' --in-reply-to '2025041744-widely-hypnosis-3013@gregkh' --subject-prefix 'PATCH 5.10.y' HEAD^.. Possible dependencies: thanks, greg k-h ------------------ original commit in Linus's tree ------------------ >From 276822a00db3c1061382b41e72cafc09d6a0ec30 Mon Sep 17 00:00:00 2001 From: Herve Codina Date: Wed, 22 Jan 2025 10:19:14 +0100 Subject: [PATCH] backlight: led_bl: Hold led_access lock when calling led_sysfs_disable() Lockdep detects the following issue on led-backlight removal: [ 142.315935] ------------[ cut here ]------------ [ 142.315954] WARNING: CPU: 2 PID: 292 at drivers/leds/led-core.c:455 led_sysfs_enable+0x54/0x80 ... [ 142.500725] Call trace: [ 142.503176] led_sysfs_enable+0x54/0x80 (P) [ 142.507370] led_bl_remove+0x80/0xa8 [led_bl] [ 142.511742] platform_remove+0x30/0x58 [ 142.515501] device_remove+0x54/0x90 ... Indeed, led_sysfs_enable() has to be called with the led_access lock held. Hold the lock when calling led_sysfs_disable(). Fixes: ae232e45acf9 ("backlight: add led-backlight driver") Cc: stable@vger.kernel.org Signed-off-by: Herve Codina Link: https://lore.kernel.org/r/20250122091914.309533-1-herve.codina@bootlin.com Signed-off-by: Lee Jones diff --git a/drivers/video/backlight/led_bl.c b/drivers/video/backlight/led_bl.c index ae34d1ecbfbe..d2db157b2c29 100644 --- a/drivers/video/backlight/led_bl.c +++ b/drivers/video/backlight/led_bl.c @@ -229,8 +229,11 @@ static void led_bl_remove(struct platform_device *pdev) backlight_device_unregister(bl); led_bl_power_off(priv); - for (i = 0; i < priv->nb_leds; i++) + for (i = 0; i < priv->nb_leds; i++) { + mutex_lock(&priv->leds[i]->led_access); led_sysfs_enable(priv->leds[i]); + mutex_unlock(&priv->leds[i]->led_access); + } } static const struct of_device_id led_bl_of_match[] = {