From: Sasha Levin <sashal@kernel.org>
To: stable@vger.kernel.org, yi.l.liu@intel.com
Cc: Sasha Levin <sashal@kernel.org>
Subject: Re: [PATCH 6.12.y] iommufd: Fail replace if device has not been attached
Date: Fri, 18 Apr 2025 11:42:41 -0400 [thread overview]
Message-ID: <20250418085713-b332a9a897f871ef@stable.kernel.org> (raw)
In-Reply-To: <20250417134743.205380-1-yi.l.liu@intel.com>
[ Sasha's backport helper bot ]
Hi,
Summary of potential issues:
⚠️ Found matching upstream commit but patch is missing proper reference to it
Found matching upstream commit: 55c85fa7579dc2e3f5399ef5bad67a44257c1a48
Status in newer kernel trees:
6.14.y | Not found
6.13.y | Not found
Note: The patch differs from the upstream commit:
---
1: 55c85fa7579dc ! 1: 5c6d205c63555 iommufd: Fail replace if device has not been attached
@@ Commit message
Reviewed-by: Kevin Tian <kevin.tian@intel.com>
Signed-off-by: Yi Liu <yi.l.liu@intel.com>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
+ (cherry picked from commit 55c85fa7579dc2e3f5399ef5bad67a44257c1a48)
+ Signed-off-by: Yi Liu <yi.l.liu@intel.com>
## drivers/iommu/iommufd/device.c ##
@@ drivers/iommu/iommufd/device.c: iommufd_device_attach_reserved_iova(struct iommufd_device *idev,
+ return 0;
+ }
- /* The device attach/detach/replace helpers for attach_handle */
-
++/* The device attach/detach/replace helpers for attach_handle */
++
+/* Check if idev is attached to igroup->hwpt */
+static bool iommufd_device_is_attached(struct iommufd_device *idev)
+{
@@ drivers/iommu/iommufd/device.c: iommufd_device_attach_reserved_iova(struct iommu
+ return false;
+}
+
- static int iommufd_hwpt_attach_device(struct iommufd_hw_pagetable *hwpt,
- struct iommufd_device *idev)
+ int iommufd_hw_pagetable_attach(struct iommufd_hw_pagetable *hwpt,
+ struct iommufd_device *idev)
{
@@ drivers/iommu/iommufd/device.c: iommufd_device_do_replace(struct iommufd_device *idev,
goto err_unlock;
---
Results of testing on various branches:
| Branch | Patch Apply | Build Test |
|---------------------------|-------------|------------|
| stable/linux-6.12.y | Success | Success |
prev parent reply other threads:[~2025-04-18 15:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-17 11:43 FAILED: patch "[PATCH] iommufd: Fail replace if device has not been attached" failed to apply to 6.12-stable tree gregkh
2025-04-17 13:47 ` [PATCH 6.12.y] iommufd: Fail replace if device has not been attached Yi Liu
2025-04-18 15:42 ` Sasha Levin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250418085713-b332a9a897f871ef@stable.kernel.org \
--to=sashal@kernel.org \
--cc=stable@vger.kernel.org \
--cc=yi.l.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox