From: Borislav Petkov <bp@alien8.de>
To: Ingo Molnar <mingo@kernel.org>,
Greg KH <gregkh@linuxfoundation.org>,
stable <stable@vger.kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-tip-commits@vger.kernel.org,
Sandipan Das <sandipan.das@amd.com>,
x86@kernel.org
Subject: Re: [tip: x86/urgent] x86/cpu/amd: Fix workaround for erratum 1054
Date: Fri, 18 Apr 2025 14:37:13 +0200 [thread overview]
Message-ID: <20250418123713.GCaAJHedTC_JWN__Td@fat_crate.local> (raw)
In-Reply-To: <aAJBgCjGpvyI43E3@gmail.com>
On Fri, Apr 18, 2025 at 02:11:44PM +0200, Ingo Molnar wrote:
> No, it doesn't really 'need' a stable tag, it has a Fixes tag already,
> which gets processed by the -stable team.
Last time I asked Greg, he said they scan for those tags but it doesn't hurt
to Cc stable as it helps.
Greg?
> Also, the bug is old, 1.5 years old:
>
> Date: Sat, 2 Dec 2023 12:50:23 +0100
>
> plus the erratum is a perf-counters information quality bug affecting
> what appears to be a limited number of models, with the workaround
No, the fix is needed because Zen2 and newer won't set
MSR_K7_HWCR_IRPERF_EN_BIT. It needs to go everywhere.
> likely incorporated in BIOS updates as well.
You can very much forget that argument. I have hard BIOS adoption data which
paints an abysmal picture. So NEVER EVER rely on BIOS to do anything.
Especially for Zen1 which is oooold in BIOS time.
> Leave it up to the -stable team whether they think it's severe enough to
> backport it?
No, they leave it to us section maintainers to decide AFAIK.
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next parent reply other threads:[~2025-04-18 12:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <174495817953.31282.5641497960291856424.tip-bot2@tip-bot2>
[not found] ` <20250418104013.GAaAIsDW2skB12L-nm@renoirsky.local>
[not found] ` <aAJBgCjGpvyI43E3@gmail.com>
2025-04-18 12:37 ` Borislav Petkov [this message]
2025-04-18 12:41 ` [tip: x86/urgent] x86/cpu/amd: Fix workaround for erratum 1054 Ingo Molnar
2025-04-18 12:47 ` Greg KH
2025-04-18 12:56 ` Ingo Molnar
2025-04-18 12:37 tip-bot2 for Sandipan Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250418123713.GCaAJHedTC_JWN__Td@fat_crate.local \
--to=bp@alien8.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=sandipan.das@amd.com \
--cc=stable@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox