From: Sasha Levin <sashal@kernel.org>
To: stable@vger.kernel.org
Cc: Yu Kuai <yukuai1@huaweicloud.com>, Sasha Levin <sashal@kernel.org>
Subject: Re: [PATCH 6.1 1/2] md: factor out a helper from mddev_put()
Date: Sat, 19 Apr 2025 08:19:30 -0400 [thread overview]
Message-ID: <20250419080717-ed4d6ead98db5c3b@stable.kernel.org> (raw)
In-Reply-To: <20250419012303.85554-2-yukuai1@huaweicloud.com>
[ Sasha's backport helper bot ]
Hi,
✅ All tests passed successfully. No issues detected.
No action required from the submitter.
The upstream commit SHA1 provided is correct: 3d8d32873c7b6d9cec5b40c2ddb8c7c55961694f
WARNING: Author mismatch between patch and upstream commit:
Backport author: Yu Kuai<yukuai1@huaweicloud.com>
Commit author: Yu Kuai<yukuai3@huawei.com>
Status in newer kernel trees:
6.14.y | Present (exact SHA1)
6.13.y | Present (exact SHA1)
6.12.y | Present (exact SHA1)
6.6.y | Present (different SHA1: 452f50807917)
Note: The patch differs from the upstream commit:
---
1: 3d8d32873c7b6 ! 1: c3ea0d86c3059 md: factor out a helper from mddev_put()
@@ Metadata
## Commit message ##
md: factor out a helper from mddev_put()
+ commit 3d8d32873c7b6d9cec5b40c2ddb8c7c55961694f upstream.
+
There are no functional changes, prepare to simplify md_seq_ops in next
patch.
Signed-off-by: Yu Kuai <yukuai3@huawei.com>
Signed-off-by: Song Liu <song@kernel.org>
Link: https://lore.kernel.org/r/20230927061241.1552837-2-yukuai1@huaweicloud.com
+ [minor context conflict]
+ Signed-off-by: Yu Kuai <yukuai3@huawei.com>
## drivers/md/md.c ##
@@ drivers/md/md.c: static inline struct mddev *mddev_get(struct mddev *mddev)
@@ drivers/md/md.c: static inline struct mddev *mddev_get(struct mddev *mddev)
+ * Call queue_work inside the spinlock so that flush_workqueue() after
+ * mddev_find will succeed in waiting for the work to be done.
+ */
++ INIT_WORK(&mddev->del_work, mddev_delayed_delete);
+ queue_work(md_misc_wq, &mddev->del_work);
+}
+
@@ drivers/md/md.c: static inline struct mddev *mddev_get(struct mddev *mddev)
- /* Array is not configured at all, and not held active,
- * so destroy it */
- set_bit(MD_DELETED, &mddev->flags);
-
+-
- /*
- * Call queue_work inside the spinlock so that
- * flush_workqueue() after mddev_find will succeed in waiting
- * for the work to be done.
- */
+- INIT_WORK(&mddev->del_work, mddev_delayed_delete);
- queue_work(md_misc_wq, &mddev->del_work);
- }
+ __mddev_put(mddev);
---
Results of testing on various branches:
| Branch | Patch Apply | Build Test |
|---------------------------|-------------|------------|
| stable/linux-6.1.y | Success | Success |
next prev parent reply other threads:[~2025-04-19 12:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-19 1:23 [PATCH 6.1 0/2] md: fix mddev uaf while iterating all_mddevs list Yu Kuai
2025-04-19 1:23 ` [PATCH 6.1 1/2] md: factor out a helper from mddev_put() Yu Kuai
2025-04-19 12:19 ` Sasha Levin [this message]
2025-04-19 1:23 ` [PATCH 6.1 2/2] md: fix mddev uaf while iterating all_mddevs list Yu Kuai
2025-04-19 12:19 ` Sasha Levin
2025-04-23 18:14 ` [PATCH 6.1 0/2] " Salvatore Bonaccorso
2025-04-24 6:40 ` Greg KH
2025-04-24 9:32 ` Salvatore Bonaccorso
2025-04-24 10:26 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250419080717-ed4d6ead98db5c3b@stable.kernel.org \
--to=sashal@kernel.org \
--cc=stable@vger.kernel.org \
--cc=yukuai1@huaweicloud.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox