From: Greg KH <gregkh@linuxfoundation.org>
To: Hardik Gohil <hgohil@mvista.com>
Cc: stable@vger.kernel.org, peter.ujfalusi@ti.com, vkoul@kernel.org,
Kunwu Chan <chentao@kylinos.cn>, Sasha Levin <sashal@kernel.org>
Subject: Re: [PATCH 3/3 v5.4.y] dmaengine: ti: edma: Add some null pointer checks to the edma_probe
Date: Tue, 22 Apr 2025 18:15:40 +0200 [thread overview]
Message-ID: <2025042204-scrambler-dropkick-e453@gregkh> (raw)
In-Reply-To: <20250422151709.26646-2-hgohil@mvista.com>
On Tue, Apr 22, 2025 at 03:17:09PM +0000, Hardik Gohil wrote:
> From: Kunwu Chan <chentao@kylinos.cn>
>
> [ Upstream commit 6e2276203ac9ff10fc76917ec9813c660f627369 ]
>
> devm_kasprintf() returns a pointer to dynamically allocated memory
> which can be NULL upon failure. Ensure the allocation was successful
> by checking the pointer validity.
>
> Signed-off-by: Kunwu Chan <chentao@kylinos.cn>
> Link: https://lore.kernel.org/r/20240118031929.192192-1-chentao@kylinos.cn
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
> Signed-off-by: Sasha Levin <sashal@kernel.org>
Sasha did not sign off on the original commit here.
And you didn't either. Please read the documentation for what this
means, and what you are doing when you add it.
thanks,
greg k-h
next prev parent reply other threads:[~2025-04-22 16:15 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-16 6:43 [PATCH 1/3 v5.4.y] dmaengine: ti: edma: Add support for handling reserved channels Hardik Gohil
2025-04-16 14:17 ` Sasha Levin
2025-04-22 13:32 ` Greg KH
[not found] ` <CAH+zgeHyLBNMz=kWw0xbfKfw2Fy6BtbWZAub6w_cTsAhNEsxSw@mail.gmail.com>
2025-04-22 14:10 ` Hardik Gohil
2025-04-22 14:11 ` Greg KH
2025-04-22 15:17 ` [PATCH 2/3 v5.4.y] dmaengine: ti: edma: add missed operations Hardik Gohil
2025-04-22 15:17 ` [PATCH 3/3 v5.4.y] dmaengine: ti: edma: Add some null pointer checks to the edma_probe Hardik Gohil
2025-04-22 16:15 ` Greg KH [this message]
2025-04-23 10:00 ` Hardik Gohil
2025-04-23 11:07 ` Greg KH
2025-04-24 6:06 ` [PATCH 2/3 v5.4.y] dmaengine: ti: edma: add missed operations Hardik Gohil
2025-04-24 6:06 ` [PATCH 3/3 v5.4.y] dmaengine: ti: edma: Add some null pointer checks to the edma_probe Hardik Gohil
2025-04-24 23:22 ` Sasha Levin
2025-04-24 23:22 ` [PATCH 2/3 v5.4.y] dmaengine: ti: edma: add missed operations Sasha Levin
2025-04-25 8:11 ` Greg KH
2025-04-24 6:08 ` [PATCH 1/3 v5.4.y] dmaengine: ti: edma: Add support for handling reserved channels Hardik Gohil
2025-04-25 1:14 ` Sasha Levin
2025-04-25 8:10 ` Greg KH
2025-04-25 8:24 ` Greg KH
2025-04-22 16:14 ` [PATCH 2/3 v5.4.y] dmaengine: ti: edma: add missed operations Greg KH
2025-04-22 19:46 ` Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025042204-scrambler-dropkick-e453@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=chentao@kylinos.cn \
--cc=hgohil@mvista.com \
--cc=peter.ujfalusi@ti.com \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox