From: Greg KH <gregkh@linuxfoundation.org>
To: Jacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org,
Karol Wachowski <karol.wachowski@intel.com>
Subject: Re: [PATCH] accel/ivpu: Add handling of VPU_JSM_STATUS_MVNCI_CONTEXT_VIOLATION_HW
Date: Tue, 22 Apr 2025 14:17:48 +0200 [thread overview]
Message-ID: <2025042227-crumb-rubble-7854@gregkh> (raw)
In-Reply-To: <20250408095711.635185-1-jacek.lawrynowicz@linux.intel.com>
On Tue, Apr 08, 2025 at 11:57:11AM +0200, Jacek Lawrynowicz wrote:
> From: Karol Wachowski <karol.wachowski@intel.com>
>
> commit dad945c27a42dfadddff1049cf5ae417209a8996 upstream.
>
> Trigger recovery of the NPU upon receiving HW context violation from
> the firmware. The context violation error is a fatal error that prevents
> any subsequent jobs from being executed. Without this fix it is
> necessary to reload the driver to restore the NPU operational state.
>
> This is simplified version of upstream commit as the full implementation
> would require all engine reset/resume logic to be backported.
We REALLY do not like taking patches that are not upstream. Why not
backport all of the needed patches instead, how many would that be?
Taking one-off patches like this just makes it harder/impossible to
maintain the code over time as further fixes in this same area will NOT
apply properly at all.
Think about what you want to be touching 5 years from now, a one-off
change that doesn't match the rest of the kernel tree, or something that
is the same?
thanks,
greg k-h
next prev parent reply other threads:[~2025-04-22 12:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-08 9:57 [PATCH] accel/ivpu: Add handling of VPU_JSM_STATUS_MVNCI_CONTEXT_VIOLATION_HW Jacek Lawrynowicz
2025-04-10 7:49 ` Jacek Lawrynowicz
2025-04-10 8:03 ` Greg Kroah-Hartman
2025-04-10 9:27 ` Jacek Lawrynowicz
2025-04-10 15:53 ` Sasha Levin
2025-04-22 12:17 ` Greg KH [this message]
2025-04-24 10:22 ` Jacek Lawrynowicz
2025-04-24 10:34 ` Greg KH
2025-04-30 12:50 ` Jacek Lawrynowicz
-- strict thread matches above, loose matches on Subject: below --
2025-04-01 11:08 Jacek Lawrynowicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025042227-crumb-rubble-7854@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=jacek.lawrynowicz@linux.intel.com \
--cc=karol.wachowski@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox