From: Greg KH <greg@kroah.com>
To: Hardik Gohil <hgohil@mvista.com>
Cc: stable@vger.kernel.org, christophe.kerello@foss.st.com,
sashal@kernel.org, ulf.hansson@linaro.org,
Yann Gautier <yann.gautier@foss.st.com>
Subject: Re: [PATCH 1/2 v5.4.y] mmc: mmci: stm32: use a buffer for unaligned DMA requests
Date: Tue, 22 Apr 2025 14:15:17 +0200 [thread overview]
Message-ID: <2025042250-difficult-surgery-cb7c@gregkh> (raw)
In-Reply-To: <1744115241-28452-1-git-send-email-hgohil@mvista.com>
On Tue, Apr 08, 2025 at 05:57:20PM +0530, Hardik Gohil wrote:
> From: Yann Gautier <yann.gautier@foss.st.com>
>
> [ Upstream commit 970dc9c11a17994ab878016b536612ab00d1441d ]
>
> In SDIO mode, the sg list for requests can be unaligned with what the
> STM32 SDMMC internal DMA can support. In that case, instead of failing,
> use a temporary bounce buffer to copy from/to the sg list.
> This buffer is limited to 1MB. But for that we need to also limit
> max_req_size to 1MB. It has not shown any throughput penalties for
> SD-cards or eMMC.
>
> Signed-off-by: Yann Gautier <yann.gautier@foss.st.com>
> Link: https://lore.kernel.org/r/20220328145114.334577-1-yann.gautier@foss.st.com
> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
> Stable-dep-of: 6b1ba3f9040b ("mmc: mmci: stm32: fix DMA API overlapping mappings warning")
> Signed-off-by: Sasha Levin <sashal@kernel.org>
> Tested-by: Hardik A Gohil <hgohil@mvista.com>
> ---
> This fix was not backported to v5.4
>
> Patch 1 and Patch 2 there were only line change.
>
> Tested build successfully
>
> dependend patch for this 2 patches
> https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=v5.10.235&id=bdbf9faf5f2e6bb0c0243350428c908ac85c16b2
Then please send the full patch series, not just "prep" patches.
I'm dropping both of these from my review queue now, thanks.
greg k-h
prev parent reply other threads:[~2025-04-22 12:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-08 12:27 [PATCH 1/2 v5.4.y] mmc: mmci: stm32: use a buffer for unaligned DMA requests Hardik Gohil
2025-04-08 12:27 ` [PATCH 2/2] mmc: mmci: stm32: fix DMA API overlapping mappings warning Hardik Gohil
2025-04-10 15:53 ` [PATCH 1/2 v5.4.y] mmc: mmci: stm32: use a buffer for unaligned DMA requests Sasha Levin
2025-04-11 13:47 ` Hardik Gohil
2025-04-22 12:15 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025042250-difficult-surgery-cb7c@gregkh \
--to=greg@kroah.com \
--cc=christophe.kerello@foss.st.com \
--cc=hgohil@mvista.com \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=yann.gautier@foss.st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox