From: Greg KH <gregkh@linuxfoundation.org>
To: Hardik Gohil <hgohil@mvista.com>
Cc: stable@vger.kernel.org, peter.ujfalusi@ti.com, vkoul@kernel.org,
Chuhong Yuan <hslester96@gmail.com>
Subject: Re: [PATCH 2/3 v5.4.y] dmaengine: ti: edma: add missed operations
Date: Tue, 22 Apr 2025 18:14:52 +0200 [thread overview]
Message-ID: <2025042253-pajamas-deprive-e058@gregkh> (raw)
In-Reply-To: <20250422151709.26646-1-hgohil@mvista.com>
On Tue, Apr 22, 2025 at 03:17:08PM +0000, Hardik Gohil wrote:
> From: Chuhong Yuan <hslester96@gmail.com>
>
> The driver forgets to call pm_runtime_disable and pm_runtime_put_sync in
> probe failure and remove.
> Add the calls and modify probe failure handling to fix it.
>
> To simplify the fix, the patch adjusts the calling order and merges checks
> for devm_kcalloc.
>
> Fixes: 2b6b3b742019 ("ARM/dmaengine: edma: Merge the two drivers under drivers/dma/")
> Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
> Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> Link: https://lore.kernel.org/r/20191124052855.6472-1-hslester96@gmail.com
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
Why did you not sign off on this?
And where is patch 1/3?
Please take a pause, and redo this after testing that you have it
correct locally, before sending it out again.
Also, properly version your patch series.
thanks,
greg k-h
next prev parent reply other threads:[~2025-04-22 16:14 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-16 6:43 [PATCH 1/3 v5.4.y] dmaengine: ti: edma: Add support for handling reserved channels Hardik Gohil
2025-04-16 14:17 ` Sasha Levin
2025-04-22 13:32 ` Greg KH
[not found] ` <CAH+zgeHyLBNMz=kWw0xbfKfw2Fy6BtbWZAub6w_cTsAhNEsxSw@mail.gmail.com>
2025-04-22 14:10 ` Hardik Gohil
2025-04-22 14:11 ` Greg KH
2025-04-22 15:17 ` [PATCH 2/3 v5.4.y] dmaengine: ti: edma: add missed operations Hardik Gohil
2025-04-22 15:17 ` [PATCH 3/3 v5.4.y] dmaengine: ti: edma: Add some null pointer checks to the edma_probe Hardik Gohil
2025-04-22 16:15 ` Greg KH
2025-04-23 10:00 ` Hardik Gohil
2025-04-23 11:07 ` Greg KH
2025-04-24 6:06 ` [PATCH 2/3 v5.4.y] dmaengine: ti: edma: add missed operations Hardik Gohil
2025-04-24 6:06 ` [PATCH 3/3 v5.4.y] dmaengine: ti: edma: Add some null pointer checks to the edma_probe Hardik Gohil
2025-04-24 23:22 ` Sasha Levin
2025-04-24 23:22 ` [PATCH 2/3 v5.4.y] dmaengine: ti: edma: add missed operations Sasha Levin
2025-04-25 8:11 ` Greg KH
2025-04-24 6:08 ` [PATCH 1/3 v5.4.y] dmaengine: ti: edma: Add support for handling reserved channels Hardik Gohil
2025-04-25 1:14 ` Sasha Levin
2025-04-25 8:10 ` Greg KH
2025-04-25 8:24 ` Greg KH
2025-04-22 16:14 ` Greg KH [this message]
2025-04-22 19:46 ` [PATCH 2/3 v5.4.y] dmaengine: ti: edma: add missed operations Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025042253-pajamas-deprive-e058@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=hgohil@mvista.com \
--cc=hslester96@gmail.com \
--cc=peter.ujfalusi@ti.com \
--cc=stable@vger.kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox