From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BB2162580E7 for ; Wed, 23 Apr 2025 07:40:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745394052; cv=none; b=uH8uA6ktqnfAfkWMkmkrFzY2C+Ra0hCv5r421Ted6pKFg+/oaWmRExXlOa6K2pZ/UdAF2yp1YLch5sh1pl8FI+pyRLFu2+SopWBC5QGKZG2M8rRZ9ffu3HhvnCExwQoHPnCE11Mv6JPUvpYCGjwFMoI+dH5X6VBKcPTyuHrBkXs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745394052; c=relaxed/simple; bh=qoca2CpMWyZds2Uu5EB4ZL2Mdcm9BXqt/2Ih1pHZvFE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=YUlCZACZ9kwO3fY/SeTTeZTYjjmBTj9RSyACpkJNGfAHKGEd+JCxKxU2ceEbaL50Jb8o29SF/wjSBE+PBSFiIWrG9Bn3H+1DdPeTjEaoIRdyTNpcltyeZtLcZUgBatQNyANer3dwECPEQi+RBxqrNufcf7zZQ4mn69mbd97ui2Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=OwvRxTPr; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="OwvRxTPr" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 98F9DC4CEE2; Wed, 23 Apr 2025 07:40:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1745394052; bh=qoca2CpMWyZds2Uu5EB4ZL2Mdcm9BXqt/2Ih1pHZvFE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OwvRxTPrEExefIPqjThVC2o8/ZBigYRy/ETdFCHd+8PECHHDX1QHBSUFHNL34t48n nvUM0shoftgIf0ofr3WkoN7KTyNdNohBothlz5eXsibTyLz0TYI52B91umcnPpfLv8 q0rS2FVrFPX9LQDx6NRBfQ9uyAzysLEig0u/iDzU= Date: Wed, 23 Apr 2025 09:39:12 +0200 From: Greg Kroah-Hartman To: Qingfang Deng Cc: David Hildenbrand , Sasha Levin , stable@vger.kernel.org, linux-mm@kvack.org, Zi Yan , Johannes Weiner , Brendan Jackman , Michal Hocko , Suren Baghdasaryan , Vlastimil Babka , Andrew Morton , Liu Xiang Subject: Re: Please apply d2155fe54ddb to 5.10 and 5.4 Message-ID: <2025042306-perfected-retake-80d3@gregkh> References: <2025042251-energize-preorder-31cd@gregkh> <2025042237-express-coconut-592c@gregkh> <7bf68ddd-7204-4a8c-b7df-03ecb6aa2ad2@redhat.com> <2025042256-unnerve-doorway-7cb7@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Wed, Apr 23, 2025 at 03:37:39PM +0800, Qingfang Deng wrote: > On Tue, Apr 22, 2025 at 8:41 PM Greg Kroah-Hartman > wrote: > > > > > > > > The commit looks harmless. But I don't see how it could fix any warning? > > > > > > > > I mean, we replace two !list_empty() checks by a single one ... and the > > > > warning is about list_cut_position() ? > > > > > > I have no idea, actually. Maybe the double !list_empty() confuses the > > > compiler, making it think `sublist` can be referenced out of the > > > scope? > > > > That is odd, are you sure this isn't a compiler bug? > > I think it is a compiler bug. If so, what should we do to fix the warning? Fix the compiler :)