From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AF604284B4B; Wed, 23 Apr 2025 15:14:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745421251; cv=none; b=hLbs8GL+aFrLr7SkDXBSQhO5myP3V1T6iBjH5LQKNW7n60OogSLcn3V1wq//qqsvSECrq3qu/hIJWyHCUt+RqlSdAzMTeOliDo4r+AvcH6M+TCeI9mBB3mCbqCikB+PYtkad73EtGMXLMg7HBdu7fzyjues9AzX3uh804NaZHPY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745421251; c=relaxed/simple; bh=+LYxqF1CO+/ywOk2AAFtdc/0EgRMhF47fJFgeJ4zW1Y=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=VIRFAVkq8oqQ/4bVoZK1UebkiOhdaQVyDYgsnFnMDRmD+4ayf/6wS+5/XrGiMbYBOz1TmHWEUHpTSEqJpQL34wcnV9cBehtojivBgjaZpet+EyWEXwJK1Ga9ENlCVV4835UCmJ24Qvhk6U/G07AY128Q65Z7YFzjVlwTC7ZILJM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=lWWHvDdL; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="lWWHvDdL" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 23B47C4CEE2; Wed, 23 Apr 2025 15:14:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1745421251; bh=+LYxqF1CO+/ywOk2AAFtdc/0EgRMhF47fJFgeJ4zW1Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lWWHvDdLcWWl+hMmo/e6db1TfucDRdr9gIDpLvg6xdiijXZXFMeSb5/6PDPilmfS4 1sEbbQpdcsE1fs8PbDWzc6PiHDbsIJk5H1e0PHk6s96x/BAOh+UmpW9SW1c+0M9Gzc 0umaHQZTF5KJM8Va8A6PrsPP0KvDNzo6n7BHIOlU= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, WangYuli , Chaitanya Kulkarni , Christoph Hellwig , Keith Busch Subject: [PATCH 6.12 205/223] nvmet-fc: Remove unused functions Date: Wed, 23 Apr 2025 16:44:37 +0200 Message-ID: <20250423142625.516547759@linuxfoundation.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250423142617.120834124@linuxfoundation.org> References: <20250423142617.120834124@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.12-stable review patch. If anyone has any objections, please let me know. ------------------ From: WangYuli commit 1b304c006b0fb4f0517a8c4ba8c46e88f48a069c upstream. The functions nvmet_fc_iodnum() and nvmet_fc_fodnum() are currently unutilized. Following commit c53432030d86 ("nvme-fabrics: Add target support for FC transport"), which introduced these two functions, they have not been used at all in practice. Remove them to resolve the compiler warnings. Fix follow errors with clang-19 when W=1e: drivers/nvme/target/fc.c:177:1: error: unused function 'nvmet_fc_iodnum' [-Werror,-Wunused-function] 177 | nvmet_fc_iodnum(struct nvmet_fc_ls_iod *iodptr) | ^~~~~~~~~~~~~~~ drivers/nvme/target/fc.c:183:1: error: unused function 'nvmet_fc_fodnum' [-Werror,-Wunused-function] 183 | nvmet_fc_fodnum(struct nvmet_fc_fcp_iod *fodptr) | ^~~~~~~~~~~~~~~ 2 errors generated. make[8]: *** [scripts/Makefile.build:207: drivers/nvme/target/fc.o] Error 1 make[7]: *** [scripts/Makefile.build:465: drivers/nvme/target] Error 2 make[6]: *** [scripts/Makefile.build:465: drivers/nvme] Error 2 make[6]: *** Waiting for unfinished jobs.... Fixes: c53432030d86 ("nvme-fabrics: Add target support for FC transport") Signed-off-by: WangYuli Reviewed-by: Chaitanya Kulkarni Reviewed-by: Christoph Hellwig Signed-off-by: Keith Busch Signed-off-by: Greg Kroah-Hartman --- drivers/nvme/target/fc.c | 14 -------------- 1 file changed, 14 deletions(-) --- a/drivers/nvme/target/fc.c +++ b/drivers/nvme/target/fc.c @@ -172,20 +172,6 @@ struct nvmet_fc_tgt_assoc { struct work_struct del_work; }; - -static inline int -nvmet_fc_iodnum(struct nvmet_fc_ls_iod *iodptr) -{ - return (iodptr - iodptr->tgtport->iod); -} - -static inline int -nvmet_fc_fodnum(struct nvmet_fc_fcp_iod *fodptr) -{ - return (fodptr - fodptr->queue->fod); -} - - /* * Association and Connection IDs: *