From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EBF39374F1; Wed, 23 Apr 2025 15:32:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745422360; cv=none; b=l6OOp+vBkRTtWcOwHMIRgpfu5jprmwim60ZtShRPUlJRdDVpQcDGwgqI9etuCtJO5il18IWYf2AOmh/ZYEZU4htAtdX8w6FLJ0t3Bk1t2fu6bhuMoKC9qMk0jpW8m7NYkVwdEvKMBy0bkyMP1daSZ3qGyphqSXaU3pGnnfiohVQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745422360; c=relaxed/simple; bh=Tsi2uHyhsI8a/owt45NN3zNc2yeedYnN93x2krk7AOQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=eW+z4fOTNnkUA3RGE81+8B+FX3ExHFnq/KE0z+ShoY/STynkvnE5UVIgnRCrK8NLRyDM/PJ5qcKvRP50W99I6CtI9re0MBf7kd0U2Sbe/XXpVZkY9HQBvBhvaBwOa02RfE7QcQP90YWRPJYeym+g1G9YBD9QFQEp4rhP4biNL48= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=uWNzJ9lo; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="uWNzJ9lo" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7D3CAC4CEE2; Wed, 23 Apr 2025 15:32:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1745422359; bh=Tsi2uHyhsI8a/owt45NN3zNc2yeedYnN93x2krk7AOQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=uWNzJ9lofJhONW6QZpSDwzj6gAgJOxmr2ntiEZeBVapSTcNSgxQ5rZryD/Cupmmfm IOgUi2gy0S9hD90OA7z5C4ILYQPFc6f6bxRQh4M+bBNfKnhFUU9wkBVUKdFGPqHVp0 wd/XeM0V7NtIFwa85EFpKdicsFa1o42QRNBRiSJs= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Manivannan Sadhasivam , Kunihiko Hayashi , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= Subject: [PATCH 6.1 262/291] misc: pci_endpoint_test: Fix displaying irq_type after request_irq error Date: Wed, 23 Apr 2025 16:44:11 +0200 Message-ID: <20250423142635.132499907@linuxfoundation.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250423142624.409452181@linuxfoundation.org> References: <20250423142624.409452181@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Kunihiko Hayashi commit 919d14603dab6a9cf03ebbeb2cfa556df48737c8 upstream. There are two variables that indicate the interrupt type to be used in the next test execution, global "irq_type" and "test->irq_type". The former is referenced from pci_endpoint_test_get_irq() to preserve the current type for ioctl(PCITEST_GET_IRQTYPE). In the pci_endpoint_test_request_irq(), since this global variable is referenced when an error occurs, the unintended error message is displayed. For example, after running "pcitest -i 2", the following message shows "MSI 3" even if the current IRQ type becomes "MSI-X": pci-endpoint-test 0000:01:00.0: Failed to request IRQ 30 for MSI 3 SET IRQ TYPE TO MSI-X: NOT OKAY Fix this issue by using "test->irq_type" instead of global "irq_type". Cc: stable@vger.kernel.org Fixes: b2ba9225e031 ("misc: pci_endpoint_test: Avoid using module parameter to determine irqtype") Reviewed-by: Manivannan Sadhasivam Signed-off-by: Kunihiko Hayashi Link: https://lore.kernel.org/r/20250225110252.28866-4-hayashi.kunihiko@socionext.com [kwilczynski: commit log] Signed-off-by: Krzysztof Wilczyński Signed-off-by: Kunihiko Hayashi Signed-off-by: Greg Kroah-Hartman --- drivers/misc/pci_endpoint_test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/misc/pci_endpoint_test.c +++ b/drivers/misc/pci_endpoint_test.c @@ -245,7 +245,7 @@ static bool pci_endpoint_test_request_ir return true; fail: - switch (irq_type) { + switch (test->irq_type) { case IRQ_TYPE_LEGACY: dev_err(dev, "Failed to request IRQ %d for Legacy\n", pci_irq_vector(pdev, i));