From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 90319284692; Wed, 23 Apr 2025 15:33:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745422400; cv=none; b=gfud8ymAKCTDL32EC2sbGWsqWHACkS+E6pCySwQuwzIm9XETaNLa6K97Q751MBs1pYVvTp0Ytl0UogW9Iq2NBADyR4i1dNxePbzGPq+ZcN9dW5xOQzD9IxSfyZhLuck46VcLEDfbGh5A19Djmj5IJNaXfmUSKpwP9VaYtkibko4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745422400; c=relaxed/simple; bh=pI3duBjXdOxwChaJNgU83E7vCLTUACN7EournJXfKQ8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=pWcFd6djkz0TMoimp7EIrHa9GxNf1v2A12ffQq2c55djnBV0h0RGdQhS0xTaEZhXYmPvNzvJo9qNCAMFOrSAO0WTwnsSyrY24PSlaKPx8+SVVPKDLEhPG9uDe5u6kUaje2IxaI8VwZQSOrUMkAsWln2zSk4WblauGztlqei4knM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=OVKTMjYM; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="OVKTMjYM" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B5A15C4CEE2; Wed, 23 Apr 2025 15:33:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1745422399; bh=pI3duBjXdOxwChaJNgU83E7vCLTUACN7EournJXfKQ8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=OVKTMjYM4LG9esMYc353zrSblvBuORuKnqA+C55OAta+bAf5P7pa1/LxftP1S6ZMQ 22EhoTX1hmfZ5w0GGadSXdQylARiMP/zYriGFDQKKbKt2DWS3TSXBN4lc5CcGeWdwT F4Axq0nwE4Xlq4kPKIvac1nVPIIgHHo8ukaeFb7M= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Denis Arefev , Namjae Jeon , Steve French Subject: [PATCH 6.6 326/393] ksmbd: Prevent integer overflow in calculation of deadtime Date: Wed, 23 Apr 2025 16:43:42 +0200 Message-ID: <20250423142656.796553369@linuxfoundation.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250423142643.246005366@linuxfoundation.org> References: <20250423142643.246005366@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Denis Arefev commit a93ff742820f75bf8bb3fcf21d9f25ca6eb3d4c6 upstream. The user can set any value for 'deadtime'. This affects the arithmetic expression 'req->deadtime * SMB_ECHO_INTERVAL', which is subject to overflow. The added check makes the server behavior more predictable. Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixes: 0626e6641f6b ("cifsd: add server handler for central processing and tranport layers") Cc: stable@vger.kernel.org Signed-off-by: Denis Arefev Acked-by: Namjae Jeon Signed-off-by: Steve French Signed-off-by: Greg Kroah-Hartman --- fs/smb/server/transport_ipc.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) --- a/fs/smb/server/transport_ipc.c +++ b/fs/smb/server/transport_ipc.c @@ -296,7 +296,11 @@ static int ipc_server_config_on_startup( server_conf.signing = req->signing; server_conf.tcp_port = req->tcp_port; server_conf.ipc_timeout = req->ipc_timeout * HZ; - server_conf.deadtime = req->deadtime * SMB_ECHO_INTERVAL; + if (check_mul_overflow(req->deadtime, SMB_ECHO_INTERVAL, + &server_conf.deadtime)) { + ret = -EINVAL; + goto out; + } server_conf.share_fake_fscaps = req->share_fake_fscaps; ksmbd_init_domain(req->sub_auth); @@ -322,6 +326,7 @@ static int ipc_server_config_on_startup( ret |= ksmbd_set_work_group(req->work_group); ret |= ksmbd_tcp_set_interfaces(KSMBD_STARTUP_CONFIG_INTERFACES(req), req->ifc_list_sz); +out: if (ret) { pr_err("Server configuration error: %s %s %s\n", req->netbios_name, req->server_string,