From: Jakub Kicinski <kuba@kernel.org>
To: Harshitha Ramamurthy <hramamurthy@google.com>
Cc: netdev@vger.kernel.org, jeroendb@google.com,
andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, pkaligineedi@google.com, willemb@google.com,
ziweixiao@google.com, shailend@google.com,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH net] gve: Add adminq lock for creating and destroying multiple queues
Date: Wed, 23 Apr 2025 17:14:31 -0700 [thread overview]
Message-ID: <20250423171431.2cd8ca21@kernel.org> (raw)
In-Reply-To: <20250417204323.3902669-1-hramamurthy@google.com>
On Thu, 17 Apr 2025 20:43:23 +0000 Harshitha Ramamurthy wrote:
> Also this patch cleans up the error handling code of
> gve_adminq_destroy_tx_queue.
> static int gve_adminq_destroy_tx_queue(struct gve_priv *priv, u32 queue_index)
> {
> union gve_adminq_command cmd;
> - int err;
>
> memset(&cmd, 0, sizeof(cmd));
> cmd.opcode = cpu_to_be32(GVE_ADMINQ_DESTROY_TX_QUEUE);
> @@ -808,11 +820,7 @@ static int gve_adminq_destroy_tx_queue(struct gve_priv *priv, u32 queue_index)
> .queue_id = cpu_to_be32(queue_index),
> };
>
> - err = gve_adminq_issue_cmd(priv, &cmd);
> - if (err)
> - return err;
> -
> - return 0;
> + return gve_adminq_issue_cmd(priv, &cmd);
> }
You mean this cleanup? That's not appropriate for a stable fix...
Could you also explain which callers of this core are not already
under rtnl_lock and/pr the netdev instance lock?
--
pw-bot: cr
next prev parent reply other threads:[~2025-04-24 0:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-17 20:43 [PATCH net] gve: Add adminq lock for creating and destroying multiple queues Harshitha Ramamurthy
2025-04-22 13:08 ` Przemek Kitszel
2025-04-24 0:14 ` Jakub Kicinski [this message]
2025-04-24 18:37 ` Ziwei Xiao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250423171431.2cd8ca21@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hramamurthy@google.com \
--cc=jeroendb@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pkaligineedi@google.com \
--cc=shailend@google.com \
--cc=stable@vger.kernel.org \
--cc=willemb@google.com \
--cc=ziweixiao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox