From: Sasha Levin <sashal@kernel.org>
To: stable@vger.kernel.org, oss-lists@triops.cz
Cc: Sasha Levin <sashal@kernel.org>
Subject: Re: [PATCH] wifi: rtw88: use ieee80211_purge_tx_queue() to purge TX skb
Date: Thu, 24 Apr 2025 21:14:46 -0400 [thread overview]
Message-ID: <20250424161853-e0ead2eb3d14df4c@stable.kernel.org> (raw)
In-Reply-To: <aAowy1C3tCewoMDT@lenoch>
[ Sasha's backport helper bot ]
Hi,
Summary of potential issues:
❌ Build failures detected
⚠️ Found matching upstream commit but patch is missing proper reference to it
Found matching upstream commit: 3e5e4a801aaf4283390cc34959c6c48f910ca5ea
WARNING: Author mismatch between patch and found commit:
Backport author: Ladislav Michl<oss-lists@triops.cz>
Commit author: Ping-Ke Shih<pkshih@realtek.com>
Note: The patch differs from the upstream commit:
---
1: 3e5e4a801aaf4 < -: ------------- wifi: rtw88: use ieee80211_purge_tx_queue() to purge TX skb
-: ------------- > 1: d12acd7bc3d4c Linux 6.14.3
---
Results of testing on various branches:
| Branch | Patch Apply | Build Test |
|---------------------------|-------------|------------|
| stable/linux-6.14.y | Success | Success |
| stable/linux-6.12.y | Success | Success |
| stable/linux-6.6.y | Success | Success |
| stable/linux-6.1.y | Success | Failed |
| stable/linux-5.15.y | Success | Failed |
| stable/linux-5.10.y | Success | Success |
| stable/linux-5.4.y | Success | Success |
Build Errors:
Build error for stable/linux-6.1.y:
drivers/net/wireless/realtek/rtw88/main.c: In function 'rtw_core_deinit':
drivers/net/wireless/realtek/rtw88/main.c:2149:9: error: implicit declaration of function 'ieee80211_purge_tx_queue'; did you mean 'ieee80211_wake_queue'? [-Wimplicit-function-declaration]
2149 | ieee80211_purge_tx_queue(rtwdev->hw, &rtwdev->tx_report.queue);
| ^~~~~~~~~~~~~~~~~~~~~~~~
| ieee80211_wake_queue
make[6]: *** [scripts/Makefile.build:250: drivers/net/wireless/realtek/rtw88/main.o] Error 1
drivers/net/wireless/realtek/rtw88/tx.c: In function 'rtw_tx_report_purge_timer':
drivers/net/wireless/realtek/rtw88/tx.c:172:9: error: implicit declaration of function 'ieee80211_purge_tx_queue'; did you mean 'ieee80211_wake_queue'? [-Wimplicit-function-declaration]
172 | ieee80211_purge_tx_queue(rtwdev->hw, &tx_report->queue);
| ^~~~~~~~~~~~~~~~~~~~~~~~
| ieee80211_wake_queue
make[6]: *** [scripts/Makefile.build:250: drivers/net/wireless/realtek/rtw88/tx.o] Error 1
make[6]: Target 'drivers/net/wireless/realtek/rtw88/' not remade because of errors.
make[5]: *** [scripts/Makefile.build:503: drivers/net/wireless/realtek/rtw88] Error 2
make[5]: Target 'drivers/net/wireless/realtek/' not remade because of errors.
make[4]: *** [scripts/Makefile.build:503: drivers/net/wireless/realtek] Error 2
make[4]: Target 'drivers/net/wireless/' not remade because of errors.
make[3]: *** [scripts/Makefile.build:503: drivers/net/wireless] Error 2
make[3]: Target 'drivers/net/' not remade because of errors.
make[2]: *** [scripts/Makefile.build:503: drivers/net] Error 2
make[2]: Target 'drivers/' not remade because of errors.
make[1]: *** [scripts/Makefile.build:503: drivers] Error 2
make[1]: Target './' not remade because of errors.
make: *** [Makefile:2010: .] Error 2
make: Target '__all' not remade because of errors.
Build error for stable/linux-5.15.y:
drivers/net/wireless/realtek/rtw88/main.c: In function 'rtw_core_deinit':
drivers/net/wireless/realtek/rtw88/main.c:1912:9: error: implicit declaration of function 'ieee80211_purge_tx_queue'; did you mean 'ieee80211_wake_queue'? [-Werror=implicit-function-declaration]
1912 | ieee80211_purge_tx_queue(rtwdev->hw, &rtwdev->tx_report.queue);
| ^~~~~~~~~~~~~~~~~~~~~~~~
| ieee80211_wake_queue
cc1: some warnings being treated as errors
make[5]: *** [scripts/Makefile.build:289: drivers/net/wireless/realtek/rtw88/main.o] Error 1
drivers/net/wireless/realtek/rtw88/tx.c: In function 'rtw_tx_report_purge_timer':
drivers/net/wireless/realtek/rtw88/tx.c:168:9: error: implicit declaration of function 'ieee80211_purge_tx_queue'; did you mean 'ieee80211_wake_queue'? [-Werror=implicit-function-declaration]
168 | ieee80211_purge_tx_queue(rtwdev->hw, &tx_report->queue);
| ^~~~~~~~~~~~~~~~~~~~~~~~
| ieee80211_wake_queue
cc1: some warnings being treated as errors
make[5]: *** [scripts/Makefile.build:289: drivers/net/wireless/realtek/rtw88/tx.o] Error 1
make[5]: Target '__build' not remade because of errors.
make[4]: *** [scripts/Makefile.build:552: drivers/net/wireless/realtek/rtw88] Error 2
make[4]: Target '__build' not remade because of errors.
make[3]: *** [scripts/Makefile.build:552: drivers/net/wireless/realtek] Error 2
make[3]: Target '__build' not remade because of errors.
make[2]: *** [scripts/Makefile.build:552: drivers/net/wireless] Error 2
make[2]: Target '__build' not remade because of errors.
make[1]: *** [scripts/Makefile.build:552: drivers/net] Error 2
make[1]: Target '__build' not remade because of errors.
make: *** [Makefile:1911: drivers] Error 2
make: Target '__all' not remade because of errors.
next prev parent reply other threads:[~2025-04-25 1:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-24 12:38 [PATCH] wifi: rtw88: use ieee80211_purge_tx_queue() to purge TX skb Ladislav Michl
2025-04-25 1:14 ` Sasha Levin [this message]
2025-04-25 7:18 ` Ladislav Michl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250424161853-e0ead2eb3d14df4c@stable.kernel.org \
--to=sashal@kernel.org \
--cc=oss-lists@triops.cz \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox