Linux kernel -stable discussions
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Hardik Gohil <hgohil@mvista.com>
Cc: stable@vger.kernel.org, peter.ujfalusi@ti.com, vkoul@kernel.org
Subject: Re: [PATCH 1/3 v5.4.y] dmaengine: ti: edma: Add support for handling reserved channels
Date: Fri, 25 Apr 2025 10:24:18 +0200	[thread overview]
Message-ID: <2025042542-cusp-sesame-000b@gregkh> (raw)
In-Reply-To: <2025042527-livestock-client-3c04@gregkh>

On Fri, Apr 25, 2025 at 10:10:58AM +0200, Greg KH wrote:
> On Thu, Apr 24, 2025 at 06:08:54AM +0000, Hardik Gohil wrote:
> > From: Peter Ujfalusi <peter.ujfalusi@ti.com>
> > 
> > Like paRAM slots, channels could be used by other cores and in this case
> > we need to make sure that the driver do not alter these channels.
> > 
> > Handle the generic dma-channel-mask property to mark channels in a bitmap
> > which can not be used by Linux and convert the legacy rsv_chans if it is
> > provided by platform_data.
> > 
> > Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> > Link: https://lore.kernel.org/r/20191025073056.25450-4-peter.ujfalusi@ti.com
> > Signed-off-by: Vinod Koul <vkoul@kernel.org>
> > Signed-off-by: Hardik Gohil <hgohil@mvista.com>
> > ---
> > The patch [dmaengine: ti: edma: Add some null pointer checks to the edma_probe] fix for CVE-2024-26771                                   needs to be backported to v5.4.y kernel.
> 
> No upstream git commit id?
> 
> Please fix and resend the whole series as a new versioned set of
> patches.

Actually, given all of the recent problems here, I recommend taking some
time off, and work with some more experienced kernel developers in your
company first, to get the experience needed in order to properly submit
kernel changes.  I'd like to see at least one other mvista.com
developer, who has such experience, sign off on your backports as well
to get someone else to catch basic problems like this before the
community is forced to do so.

thanks,

greg k-h

  reply	other threads:[~2025-04-25  8:24 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-16  6:43 [PATCH 1/3 v5.4.y] dmaengine: ti: edma: Add support for handling reserved channels Hardik Gohil
2025-04-16 14:17 ` Sasha Levin
2025-04-22 13:32 ` Greg KH
     [not found]   ` <CAH+zgeHyLBNMz=kWw0xbfKfw2Fy6BtbWZAub6w_cTsAhNEsxSw@mail.gmail.com>
2025-04-22 14:10     ` Hardik Gohil
2025-04-22 14:11     ` Greg KH
2025-04-22 15:17       ` [PATCH 2/3 v5.4.y] dmaengine: ti: edma: add missed operations Hardik Gohil
2025-04-22 15:17         ` [PATCH 3/3 v5.4.y] dmaengine: ti: edma: Add some null pointer checks to the edma_probe Hardik Gohil
2025-04-22 16:15           ` Greg KH
2025-04-23 10:00             ` Hardik Gohil
2025-04-23 11:07               ` Greg KH
2025-04-24  6:06                 ` [PATCH 2/3 v5.4.y] dmaengine: ti: edma: add missed operations Hardik Gohil
2025-04-24  6:06                   ` [PATCH 3/3 v5.4.y] dmaengine: ti: edma: Add some null pointer checks to the edma_probe Hardik Gohil
2025-04-24 23:22                     ` Sasha Levin
2025-04-24 23:22                   ` [PATCH 2/3 v5.4.y] dmaengine: ti: edma: add missed operations Sasha Levin
2025-04-25  8:11                   ` Greg KH
2025-04-24  6:08                 ` [PATCH 1/3 v5.4.y] dmaengine: ti: edma: Add support for handling reserved channels Hardik Gohil
2025-04-25  1:14                   ` Sasha Levin
2025-04-25  8:10                   ` Greg KH
2025-04-25  8:24                     ` Greg KH [this message]
2025-04-22 16:14         ` [PATCH 2/3 v5.4.y] dmaengine: ti: edma: add missed operations Greg KH
2025-04-22 19:46         ` Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2025042542-cusp-sesame-000b@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=hgohil@mvista.com \
    --cc=peter.ujfalusi@ti.com \
    --cc=stable@vger.kernel.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox