From: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Kuen-Han Tsai <khtsai@google.com>,
Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH v2] usb: dwc3: Abort suspend on soft disconnect failure
Date: Sat, 26 Apr 2025 00:41:32 +0000 [thread overview]
Message-ID: <20250426004128.icwn74kz57swbkid@synopsys.com> (raw)
In-Reply-To: <2025042513-crunching-sandworm-75c5@gregkh>
On Fri, Apr 25, 2025, Greg KH wrote:
> On Mon, Mar 24, 2025 at 11:17:55AM +0800, Kuen-Han Tsai wrote:
> > When dwc3_gadget_soft_disconnect() fails, dwc3_suspend_common() keeps
> > going with the suspend, resulting in a period where the power domain is
> > off, but the gadget driver remains connected. Within this time frame,
> > invoking vbus_event_work() will cause an error as it attempts to access
> > DWC3 registers for endpoint disabling after the power domain has been
> > completely shut down.
> >
> > Abort the suspend sequence when dwc3_gadget_suspend() cannot halt the
> > controller and proceeds with a soft connect.
> >
> > Fixes: c8540870af4c ("usb: dwc3: gadget: Improve dwc3_gadget_suspend()
> > and dwc3_gadget_resume()")
>
> Please do not line-wrap this type of thing.
>
> thanks,
>
> greg k-h
Did you check the latest change in v4:
https://lore.kernel.org/linux-usb/20250422221854.yl7ypzc4kkxbxw2a@synopsys.com/T/#m3ceb6dfb7b8a9681c456d410b9fcc1cc2869a447
I Acked that.
BR,
Thinh
prev parent reply other threads:[~2025-04-26 0:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-24 3:17 [PATCH v2] usb: dwc3: Abort suspend on soft disconnect failure Kuen-Han Tsai
2025-03-26 23:01 ` Thinh Nguyen
2025-03-27 13:37 ` Kuen-Han Tsai
2025-04-25 10:58 ` Greg KH
2025-04-26 0:41 ` Thinh Nguyen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250426004128.icwn74kz57swbkid@synopsys.com \
--to=thinh.nguyen@synopsys.com \
--cc=gregkh@linuxfoundation.org \
--cc=khtsai@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox