From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 88550241664; Tue, 29 Apr 2025 17:10:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745946654; cv=none; b=up/MvC2WzDblj2lhLk/8dX1UdWFbrREOV1kB1/K0gv/18d73K5IApZobUIGAKjDYDqCCbaLXNvnfd3/OrvszIrIZiZncxD26CbcTx1mJNrAP6BXnnejFmZGOBLML/olIelQqvqqZTyZJjRig+tcqCyDxVklU1OHteGNb5y1P2kY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745946654; c=relaxed/simple; bh=75Lyl9qHlfmarw9LTIwH4wXuo8taYrct8RHzN0iiaYQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=igjFc6lZBSQPbDoLYsEzUzxdkzIfcitDNDIltK2A4jaCvQC2moUirEymP11RNdiXlAPvj1qwZj450cSkQCVCthqwLYs59NRnSsQDmRxGtI7f6nLnv5oEoqxEwAQzMATnSKpqowVz8GFhABOLiuYMZUx2MCR63PXS+FW0ddSoVDU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=reRYfzEa; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="reRYfzEa" Received: by smtp.kernel.org (Postfix) with ESMTPSA id EC89BC4CEE3; Tue, 29 Apr 2025 17:10:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1745946654; bh=75Lyl9qHlfmarw9LTIwH4wXuo8taYrct8RHzN0iiaYQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=reRYfzEaxzrNLfu8NHiQok6L7uyv3yl1WGvwfCcxC8LZk1dYXYW8MwvWN9IJ79J53 5VNCQZrcmAXxPFfFoqstVZKMOkmWUdwiZtoEmWtQ+6q+y/a5JXUi5JAaa4s7md2WqQ Ifur9pWi0BhKPvkRZT0MpYQOgrMmTem6sgP19nkI= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Edward Adam Davis , Dave Kleikamp , Sasha Levin , syzbot+7c808908291a569281a9@syzkaller.appspotmail.com Subject: [PATCH 5.10 025/286] jfs: add sanity check for agwidth in dbMount Date: Tue, 29 Apr 2025 18:38:49 +0200 Message-ID: <20250429161108.887759560@linuxfoundation.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250429161107.848008295@linuxfoundation.org> References: <20250429161107.848008295@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Edward Adam Davis [ Upstream commit ddf2846f22e8575d6b4b6a66f2100f168b8cd73d ] The width in dmapctl of the AG is zero, it trigger a divide error when calculating the control page level in dbAllocAG. To avoid this issue, add a check for agwidth in dbAllocAG. Reported-and-tested-by: syzbot+7c808908291a569281a9@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=7c808908291a569281a9 Signed-off-by: Edward Adam Davis Signed-off-by: Dave Kleikamp Signed-off-by: Sasha Levin --- fs/jfs/jfs_dmap.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/fs/jfs/jfs_dmap.c b/fs/jfs/jfs_dmap.c index 3cc10f9bf9f8b..8f4c55c711ba0 100644 --- a/fs/jfs/jfs_dmap.c +++ b/fs/jfs/jfs_dmap.c @@ -204,6 +204,10 @@ int dbMount(struct inode *ipbmap) bmp->db_aglevel = le32_to_cpu(dbmp_le->dn_aglevel); bmp->db_agheight = le32_to_cpu(dbmp_le->dn_agheight); bmp->db_agwidth = le32_to_cpu(dbmp_le->dn_agwidth); + if (!bmp->db_agwidth) { + err = -EINVAL; + goto err_release_metapage; + } bmp->db_agstart = le32_to_cpu(dbmp_le->dn_agstart); bmp->db_agl2size = le32_to_cpu(dbmp_le->dn_agl2size); if (bmp->db_agl2size > L2MAXL2SIZE - L2MAXAG || -- 2.39.5