From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0FBA72459E1; Tue, 29 Apr 2025 17:11:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745946667; cv=none; b=bii2jTCb2kjopH6qzHWTKN/AgrwcvRpkmmi7Y12dcL7bZYJq5XE8voTV/TeFisuBDwvb3BprAzc1fkaVvWpacPcmPJvYxn+5j6MrZU/HnidgrvYDuI+IaYGEPn5MmEy00gTY7yLYzVm2Sk4Eh/9Nv5HuKrPtsT1EduXNSqOOyws= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745946667; c=relaxed/simple; bh=puuRmcX9hhU/kSQj48Zj3SI/kakvRPQoMAC1XLdJ9Yg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=u+T/5QXLM1CcCwkgxk6L58HsYFuEwQuwlUzqz5sJD6re5r8MDwRCitD5+ywriOeqyAOQjpLYZJ7dwBwHFDImd+0LugmjOe/ol17oagngZ5b2atqtutoKR3jPzz4RGRrD890NTZdTioma/XMywO1nOOE562ieLS/ayteYUO35qQ8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=kzSuiq7G; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="kzSuiq7G" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 97989C4CEE3; Tue, 29 Apr 2025 17:11:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1745946666; bh=puuRmcX9hhU/kSQj48Zj3SI/kakvRPQoMAC1XLdJ9Yg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kzSuiq7GuW2JKhqZVhXj/kg5i+uay5tqVlR1MawGss+dBvGRNJldmIEg7oP/+MZZg RsqQedStuv7S5xaCD0XqgyQbo5SpYgWd3IU0bC+l1RWCcsWTF6wNfxHc/Z6aPjanLC fEj/mlC3wvgCvRTGbRwfvAeL7X27aRVkfjmcpRxM= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Jan Kara , Ojaswin Mujoo , Baokun Li , Theodore Tso , Sasha Levin Subject: [PATCH 5.10 029/286] ext4: protect ext4_release_dquot against freezing Date: Tue, 29 Apr 2025 18:38:53 +0200 Message-ID: <20250429161109.057423483@linuxfoundation.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250429161107.848008295@linuxfoundation.org> References: <20250429161107.848008295@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Ojaswin Mujoo [ Upstream commit 530fea29ef82e169cd7fe048c2b7baaeb85a0028 ] Protect ext4_release_dquot against freezing so that we don't try to start a transaction when FS is frozen, leading to warnings. Further, avoid taking the freeze protection if a transaction is already running so that we don't need end up in a deadlock as described in 46e294efc355 ext4: fix deadlock with fs freezing and EA inodes Suggested-by: Jan Kara Signed-off-by: Ojaswin Mujoo Reviewed-by: Baokun Li Reviewed-by: Jan Kara Link: https://patch.msgid.link/20241121123855.645335-3-ojaswin@linux.ibm.com Signed-off-by: Theodore Ts'o Signed-off-by: Sasha Levin --- fs/ext4/super.c | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/fs/ext4/super.c b/fs/ext4/super.c index 20e89ffe9a068..1e60d957b7c15 100644 --- a/fs/ext4/super.c +++ b/fs/ext4/super.c @@ -6251,12 +6251,25 @@ static int ext4_release_dquot(struct dquot *dquot) { int ret, err; handle_t *handle; + bool freeze_protected = false; + + /* + * Trying to sb_start_intwrite() in a running transaction + * can result in a deadlock. Further, running transactions + * are already protected from freezing. + */ + if (!ext4_journal_current_handle()) { + sb_start_intwrite(dquot->dq_sb); + freeze_protected = true; + } handle = ext4_journal_start(dquot_to_inode(dquot), EXT4_HT_QUOTA, EXT4_QUOTA_DEL_BLOCKS(dquot->dq_sb)); if (IS_ERR(handle)) { /* Release dquot anyway to avoid endless cycle in dqput() */ dquot_release(dquot); + if (freeze_protected) + sb_end_intwrite(dquot->dq_sb); return PTR_ERR(handle); } ret = dquot_release(dquot); @@ -6267,6 +6280,10 @@ static int ext4_release_dquot(struct dquot *dquot) err = ext4_journal_stop(handle); if (!ret) ret = err; + + if (freeze_protected) + sb_end_intwrite(dquot->dq_sb); + return ret; } -- 2.39.5