From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3858E253334; Tue, 29 Apr 2025 16:57:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745945850; cv=none; b=XuirPXrndFSMvHucNKaNl0V5Wrtlkg+dFHZEFJyRDC1rMr0szlZlZtjDPcK7hwhBnQPB4+MZvKzeXuQjozTPtv6n4vzNxf4GH0rtkOFBTKGQT1eA23lcPdOFXLTSXqsreXS3Tdq0aMfrWhuXjlfuEgHgacDm/INhfxu/FbZQSsM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745945850; c=relaxed/simple; bh=hsA7nAGmkRh/Q9eC7kcwnzBzmaThCwd+71SBWmY3pxs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=E1BLhxfl1IvOHAM8Xy/MU2Wf2Vm1wblv/2fpGtaNDlmk/HympcPcgW+7XF8boJ1ISmSZoHIoTYXgGbxBxSPneQMfjEbMakrkmiFhItNji0Ipx5xqgxjHE6XYH5w7KrFl4Z/0KHN1Pd/EDORTCzW/OBwmCtWC2/7TgV/HDIGr5rc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=VL6gL8xU; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="VL6gL8xU" Received: by smtp.kernel.org (Postfix) with ESMTPSA id ACDE0C4CEE9; Tue, 29 Apr 2025 16:57:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1745945850; bh=hsA7nAGmkRh/Q9eC7kcwnzBzmaThCwd+71SBWmY3pxs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=VL6gL8xU2nOwynJCawmzMSh9sX6BBDw+8oW/QnDyXsjcdSZi24gig8glUNNjVXNBV Uqh4WuW+eFDD05ZcgkhSDORQg9gGTSjVvqmoKqtt1a4xtTRq1lUK2HeYwGCt1Bh3k6 MxNUoIqOObsy3u/DHsKj/gK552ZO0myfEORKiux0= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Daniel Golle , "Chester A. Unal" , Jakub Kicinski , Sasha Levin Subject: [PATCH 6.14 070/311] net: dsa: mt7530: sync driver-specific behavior of MT7531 variants Date: Tue, 29 Apr 2025 18:38:27 +0200 Message-ID: <20250429161123.910557898@linuxfoundation.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250429161121.011111832@linuxfoundation.org> References: <20250429161121.011111832@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Daniel Golle [ Upstream commit 497041d763016c2e8314d2f6a329a9b77c3797ca ] MT7531 standalone and MMIO variants found in MT7988 and EN7581 share most basic properties. Despite that, assisted_learning_on_cpu_port and mtu_enforcement_ingress were only applied for MT7531 but not for MT7988 or EN7581, causing the expected issues on MMIO devices. Apply both settings equally also for MT7988 and EN7581 by moving both assignments form mt7531_setup() to mt7531_setup_common(). This fixes unwanted flooding of packets due to unknown unicast during DA lookup, as well as issues with heterogenous MTU settings. Fixes: 7f54cc9772ce ("net: dsa: mt7530: split-off common parts from mt7531_setup") Signed-off-by: Daniel Golle Reviewed-by: Chester A. Unal Link: https://patch.msgid.link/89ed7ec6d4fa0395ac53ad2809742bb1ce61ed12.1745290867.git.daniel@makrotopia.org Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/net/dsa/mt7530.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/dsa/mt7530.c b/drivers/net/dsa/mt7530.c index 5883eb93efb11..22513f3d56db1 100644 --- a/drivers/net/dsa/mt7530.c +++ b/drivers/net/dsa/mt7530.c @@ -2541,6 +2541,9 @@ mt7531_setup_common(struct dsa_switch *ds) struct mt7530_priv *priv = ds->priv; int ret, i; + ds->assisted_learning_on_cpu_port = true; + ds->mtu_enforcement_ingress = true; + mt753x_trap_frames(priv); /* Enable and reset MIB counters */ @@ -2688,9 +2691,6 @@ mt7531_setup(struct dsa_switch *ds) if (ret) return ret; - ds->assisted_learning_on_cpu_port = true; - ds->mtu_enforcement_ingress = true; - return 0; } -- 2.39.5