From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 659621C6B4; Tue, 29 Apr 2025 17:36:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745948197; cv=none; b=WbcxPtYj+g9TyvsFXKpFMQxcm2WvuUeEBrKPYmaX444GZs0o8ARsPzJUC4R6WRxb07s6pZVY1lCZm0mRUJVmwDPlCkxb0/SjMTnPvgAAs+gD2LfgZw2dYo4CNN5nYAMzch/8vOCRlN3gFk7QqImnxzXXOPfHd9m+w2OzVd5Ql0s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745948197; c=relaxed/simple; bh=voxzmSVG6Y18qdMgMnuI0v/d7R0uz2vku6X+ZVcyXjk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=YE4XeWcrsrk+dq/tbnqyVroRvFouPEClQ8qVL1lFO8I1BwRnAKYgXFZik5W+yk2W1DMIYrPoPJtAmeC1aDgBLQK8xRGJSluoOGKiwG7RHzLdi+4koM2puVDLCu4ahAOoS4Z8nbzD2dK3MqkGp2Fq6EaDkm80xlFaCjAZTvDcBU8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=2MVTP1J6; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="2MVTP1J6" Received: by smtp.kernel.org (Postfix) with ESMTPSA id ED93CC4CEE3; Tue, 29 Apr 2025 17:36:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1745948197; bh=voxzmSVG6Y18qdMgMnuI0v/d7R0uz2vku6X+ZVcyXjk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=2MVTP1J6KDONd7Mu1yGMafh64GDfpHEuNPJoE7X1DDAZA/55We3OwmIjTPtQlB3OV WERQ1FkRo+F/+Xb5o/Un7dbZVx68DfObLWBhoq2QbS/L6kSyOvQ34jpkB1s3svFHaX XamOXkf4zUSfTXbQph6lOZckleyGCb0QcNLOAHgI= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Yi Lai , Qiuxu Zhuo , Shuah Khan , Sasha Levin Subject: [PATCH 6.12 217/280] selftests/mincore: Allow read-ahead pages to reach the end of the file Date: Tue, 29 Apr 2025 18:42:38 +0200 Message-ID: <20250429161124.002261755@linuxfoundation.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250429161115.008747050@linuxfoundation.org> References: <20250429161115.008747050@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.12-stable review patch. If anyone has any objections, please let me know. ------------------ From: Qiuxu Zhuo [ Upstream commit 197c1eaa7ba633a482ed7588eea6fd4aa57e08d4 ] When running the mincore_selftest on a system with an XFS file system, it failed the "check_file_mmap" test case due to the read-ahead pages reaching the end of the file. The failure log is as below: RUN global.check_file_mmap ... mincore_selftest.c:264:check_file_mmap:Expected i (1024) < vec_size (1024) mincore_selftest.c:265:check_file_mmap:Read-ahead pages reached the end of the file check_file_mmap: Test failed FAIL global.check_file_mmap This is because the read-ahead window size of the XFS file system on this machine is 4 MB, which is larger than the size from the #PF address to the end of the file. As a result, all the pages for this file are populated. blockdev --getra /dev/nvme0n1p5 8192 blockdev --getbsz /dev/nvme0n1p5 512 This issue can be fixed by extending the current FILE_SIZE 4MB to a larger number, but it will still fail if the read-ahead window size of the file system is larger enough. Additionally, in the real world, read-ahead pages reaching the end of the file can happen and is an expected behavior. Therefore, allowing read-ahead pages to reach the end of the file is a better choice for the "check_file_mmap" test case. Link: https://lore.kernel.org/r/20250311080940.21413-1-qiuxu.zhuo@intel.com Reported-by: Yi Lai Signed-off-by: Qiuxu Zhuo Signed-off-by: Shuah Khan Signed-off-by: Sasha Levin --- tools/testing/selftests/mincore/mincore_selftest.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/tools/testing/selftests/mincore/mincore_selftest.c b/tools/testing/selftests/mincore/mincore_selftest.c index e949a43a61450..efabfcbe0b498 100644 --- a/tools/testing/selftests/mincore/mincore_selftest.c +++ b/tools/testing/selftests/mincore/mincore_selftest.c @@ -261,9 +261,6 @@ TEST(check_file_mmap) TH_LOG("No read-ahead pages found in memory"); } - EXPECT_LT(i, vec_size) { - TH_LOG("Read-ahead pages reached the end of the file"); - } /* * End of the readahead window. The rest of the pages shouldn't * be in memory. -- 2.39.5