From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C6A8C25484F; Tue, 29 Apr 2025 17:54:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745949248; cv=none; b=IZJEQWcXTtLJzdtPNz9Mq0DwgS6LcLr5oc2oLuSkAj9XUyosMai+TgkePPjsOURaujnHNM7v4BzbjCVmaL9bs5Ebf7dDJz2saEJq32BSRymqwnvLUhWjTdhQEZJWqaDNtNWZ3h456Ch2pxMcmZR+NNnGcy4S3rz95PEWyuQiBmo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745949248; c=relaxed/simple; bh=pO+0CGhKLmxoBVGKSoYzZNUZm5hoYfqdRTdVoLloqd0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=d046rEH+MxiCIXUDPLyhoS7xT+jB+xWwLQnSVlae5iNHb0ebXUzflfnwVYkEC5VQZiXqy9bmOqsgOOtSg8hRctHvoJnQsY9zxlVjIn4P3vgWacZ10l1kUk13p7zMGlGK0Le1wubJ1FBEjsc1kL+BwwdvA6XKbQ7ESqVW0/2X/Xc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=ktHQFvZx; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="ktHQFvZx" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 46190C4CEE9; Tue, 29 Apr 2025 17:54:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1745949248; bh=pO+0CGhKLmxoBVGKSoYzZNUZm5hoYfqdRTdVoLloqd0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ktHQFvZxQDkUsqVFq8PaXDQRc1okVfAUFbDO61yKVfyWdmCkzzOMMsiO/RDxFOIrH lIp/olohSJX6MhSpRxzwMLYepRGVNzDXYQN6TWDpXmfZzUm+m8VwtrFB07VOviV/dK 6DgMAOA0igjzW96kn5Z8M53JRKOFLav4fEkdJEfs= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, syzbot+34008406ee9a31b13c73@syzkaller.appspotmail.com, Murad Masimov , Sean Young , Hans Verkuil , Sasha Levin Subject: [PATCH 5.15 259/373] media: streamzap: fix race between device disconnection and urb callback Date: Tue, 29 Apr 2025 18:42:16 +0200 Message-ID: <20250429161133.775380874@linuxfoundation.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250429161123.119104857@linuxfoundation.org> References: <20250429161123.119104857@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Murad Masimov [ Upstream commit f656cfbc7a293a039d6a0c7100e1c846845148c1 ] Syzkaller has reported a general protection fault at function ir_raw_event_store_with_filter(). This crash is caused by a NULL pointer dereference of dev->raw pointer, even though it is checked for NULL in the same function, which means there is a race condition. It occurs due to the incorrect order of actions in the streamzap_disconnect() function: rc_unregister_device() is called before usb_kill_urb(). The dev->raw pointer is freed and set to NULL in rc_unregister_device(), and only after that usb_kill_urb() waits for in-progress requests to finish. If rc_unregister_device() is called while streamzap_callback() handler is not finished, this can lead to accessing freed resources. Thus rc_unregister_device() should be called after usb_kill_urb(). Found by Linux Verification Center (linuxtesting.org) with Syzkaller. Fixes: 8e9e60640067 ("V4L/DVB: staging/lirc: port lirc_streamzap to ir-core") Cc: stable@vger.kernel.org Reported-by: syzbot+34008406ee9a31b13c73@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=34008406ee9a31b13c73 Signed-off-by: Murad Masimov Signed-off-by: Sean Young Signed-off-by: Hans Verkuil Signed-off-by: Sasha Levin --- drivers/media/rc/streamzap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/rc/streamzap.c b/drivers/media/rc/streamzap.c index d4b38532c7b44..d31ee190301b3 100644 --- a/drivers/media/rc/streamzap.c +++ b/drivers/media/rc/streamzap.c @@ -431,8 +431,8 @@ static void streamzap_disconnect(struct usb_interface *interface) if (!sz) return; - rc_unregister_device(sz->rdev); usb_kill_urb(sz->urb_in); + rc_unregister_device(sz->rdev); usb_free_urb(sz->urb_in); usb_free_coherent(usbdev, sz->buf_in_len, sz->buf_in, sz->dma_in); -- 2.39.5