From: Sasha Levin <sashal@kernel.org>
To: stable@vger.kernel.org
Cc: Carlos Llamas <cmllamas@google.com>, Sasha Levin <sashal@kernel.org>
Subject: Re: [PATCH 6.12.y] binder: fix offset calculation in debug log
Date: Thu, 1 May 2025 15:09:47 -0400 [thread overview]
Message-ID: <20250501071012-0c992678f5478372@stable.kernel.org> (raw)
In-Reply-To: <20250429225158.3920681-1-cmllamas@google.com>
[ Sasha's backport helper bot ]
Hi,
✅ All tests passed successfully. No issues detected.
No action required from the submitter.
The upstream commit SHA1 provided is correct: 170d1a3738908eef6a0dbf378ea77fb4ae8e294d
Status in newer kernel trees:
6.14.y | Present (different SHA1: c8f9ccac8a5b)
Note: The patch differs from the upstream commit:
---
1: 170d1a3738908 ! 1: 1eec0d8c91a39 binder: fix offset calculation in debug log
@@ Metadata
## Commit message ##
binder: fix offset calculation in debug log
+ commit 170d1a3738908eef6a0dbf378ea77fb4ae8e294d upstream.
+
The vma start address should be substracted from the buffer's user data
address and not the other way around.
@@ Commit message
Reviewed-by: Tiffany Y. Yang <ynaffit@google.com>
Link: https://lore.kernel.org/r/20250325184902.587138-1-cmllamas@google.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+ [cmllamas: fix conflicts due to alloc->buffer renaming]
+ Signed-off-by: Carlos Llamas <cmllamas@google.com>
## drivers/android/binder.c ##
@@ drivers/android/binder.c: static void print_binder_transaction_ilocked(struct seq_file *m,
seq_printf(m, " node %d", buffer->target_node->debug_id);
seq_printf(m, " size %zd:%zd offset %lx\n",
buffer->data_size, buffer->offsets_size,
-- proc->alloc.vm_start - buffer->user_data);
-+ buffer->user_data - proc->alloc.vm_start);
+- proc->alloc.buffer - buffer->user_data);
++ buffer->user_data - proc->alloc.buffer);
}
static void print_binder_work_ilocked(struct seq_file *m,
---
Results of testing on various branches:
| Branch | Patch Apply | Build Test |
|---------------------------|-------------|------------|
| stable/linux-6.12.y | Success | Success |
prev parent reply other threads:[~2025-05-01 19:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-28 11:58 FAILED: patch "[PATCH] binder: fix offset calculation in debug log" failed to apply to 6.12-stable tree gregkh
2025-04-29 22:51 ` [PATCH 6.12.y] binder: fix offset calculation in debug log Carlos Llamas
2025-05-01 19:09 ` Sasha Levin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250501071012-0c992678f5478372@stable.kernel.org \
--to=sashal@kernel.org \
--cc=cmllamas@google.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox