From: Al Viro <viro@zeniv.linux.org.uk>
To: Andrey Kriulin <kitotavrik.s@gmail.com>
Cc: Christian Brauner <brauner@kernel.org>,
Andrey Kriulin <kitotavrik.media@gmail.com>,
"Matthew Wilcox (Oracle)" <willy@infradead.org>,
Josef Bacik <josef@toxicpanda.com>, NeilBrown <neilb@suse.de>,
Jan Kara <jack@suse.cz>,
linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org,
stable@vger.kernel.org
Subject: Re: [PATCH] fs: minix: Fix handling of corrupted directories
Date: Fri, 2 May 2025 18:13:16 +0100 [thread overview]
Message-ID: <20250502171316.GY2023217@ZenIV> (raw)
In-Reply-To: <20250502165059.63012-1-kitotavrik.media@gmail.com>
On Fri, May 02, 2025 at 07:50:57PM +0300, Andrey Kriulin wrote:
> If the directory is corrupted and the number of nlinks is less than 2
> (valid nlinks have at least 2), then when the directory is deleted, the
> minix_rmdir will try to reduce the nlinks(unsigned int) to a negative
> value.
>
> Make nlinks validity check for directory in minix_lookup.
Not sure it's a good mitigation strategy - if nothing else, doing that
on r/o filesystem is clear loss...
next prev parent reply other threads:[~2025-05-02 17:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-02 16:50 [PATCH] fs: minix: Fix handling of corrupted directories Andrey Kriulin
2025-05-02 17:13 ` Al Viro [this message]
2025-05-02 17:27 ` Matthew Wilcox
2025-05-05 10:19 ` Jan Kara
-- strict thread matches above, loose matches on Subject: below --
2025-05-02 16:43 Andrey Kriulin
2025-05-05 10:15 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250502171316.GY2023217@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=brauner@kernel.org \
--cc=jack@suse.cz \
--cc=josef@toxicpanda.com \
--cc=kitotavrik.media@gmail.com \
--cc=kitotavrik.s@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
--cc=neilb@suse.de \
--cc=stable@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox