stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Jacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com>
Cc: stable@vger.kernel.org, Karol Wachowski <karol.wachowski@intel.com>
Subject: Re: [PATCH 5/7] accel/ivpu: Abort all jobs after command queue unregister
Date: Mon, 5 May 2025 08:03:34 +0200	[thread overview]
Message-ID: <2025050504-change-ignore-e99d@gregkh> (raw)
In-Reply-To: <20250430124819.3761263-6-jacek.lawrynowicz@linux.intel.com>

On Wed, Apr 30, 2025 at 02:48:17PM +0200, Jacek Lawrynowicz wrote:
> From: Karol Wachowski <karol.wachowski@intel.com>
> 
> commit 5bbccadaf33eea2b879d8326ad59ae0663be47d1 upstream.
> 
> With hardware scheduler it is not expected to receive JOB_DONE
> notifications from NPU FW for the jobs aborted due to command queue destroy
> JSM command.
> 
> Remove jobs submitted to unregistered command queue from submitted_jobs_xa
> to avoid triggering a TDR in such case.
> 
> Add explicit submitted_jobs_lock that protects access to list of submitted
> jobs which is now used to find jobs to abort.
> 
> Move context abort procedure to separate work queue not to slow down
> handling of IPCs or DCT requests in case where job abort takes longer,
> especially when destruction of the last job of a specific context results
> in context release.
> 
> Cc: <stable@vger.kernel.org> # v6.12
> Signed-off-by: Karol Wachowski <karol.wachowski@intel.com>
> Signed-off-by: Maciej Falkowski <maciej.falkowski@linux.intel.com>
> Reviewed-by: Jacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com>
> Signed-off-by: Jacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com>
> Link: https://patchwork.freedesktop.org/patch/msgid/20250107173238.381120-4-maciej.falkowski@linux.intel.com
> ---
>  drivers/accel/ivpu/ivpu_drv.c   | 32 +++----------
>  drivers/accel/ivpu/ivpu_drv.h   |  2 +
>  drivers/accel/ivpu/ivpu_job.c   | 82 +++++++++++++++++++++++++--------
>  drivers/accel/ivpu/ivpu_job.h   |  1 +
>  drivers/accel/ivpu/ivpu_mmu.c   |  3 +-
>  drivers/accel/ivpu/ivpu_sysfs.c |  5 +-
>  6 files changed, 77 insertions(+), 48 deletions(-)

Again, this is different from the original, so please document it as
such.

Please fix up both backported series of patches and resubmit a v2 of
them.

thanks,

greg k-h

  parent reply	other threads:[~2025-05-05  6:03 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-30 12:48 [PATCH 0/7] accel/ivpu: Add context violation handling for 6.12 Jacek Lawrynowicz
2025-04-30 12:48 ` [PATCH 1/7] accel/ivpu: Make DB_ID and JOB_ID allocations incremental Jacek Lawrynowicz
2025-05-01 19:10   ` Sasha Levin
2025-04-30 12:48 ` [PATCH 2/7] accel/ivpu: Use xa_alloc_cyclic() instead of custom function Jacek Lawrynowicz
2025-05-01 19:09   ` Sasha Levin
2025-04-30 12:48 ` [PATCH 3/7] accel/ivpu: Fix a typo Jacek Lawrynowicz
2025-05-01 19:10   ` Sasha Levin
2025-04-30 12:48 ` [PATCH 4/7] accel/ivpu: Update VPU FW API headers Jacek Lawrynowicz
2025-05-01 18:51   ` Sasha Levin
2025-04-30 12:48 ` [PATCH 5/7] accel/ivpu: Abort all jobs after command queue unregister Jacek Lawrynowicz
2025-05-01 19:12   ` Sasha Levin
2025-05-05  6:03   ` Greg KH [this message]
2025-05-05 10:34     ` Jacek Lawrynowicz
2025-04-30 12:48 ` [PATCH 6/7] accel/ivpu: Fix locking order in ivpu_job_submit Jacek Lawrynowicz
2025-05-01 18:50   ` Sasha Levin
2025-04-30 12:48 ` [PATCH 7/7] accel/ivpu: Add handling of VPU_JSM_STATUS_MVNCI_CONTEXT_VIOLATION_HW Jacek Lawrynowicz
2025-05-01 19:11   ` Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2025050504-change-ignore-e99d@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=jacek.lawrynowicz@linux.intel.com \
    --cc=karol.wachowski@intel.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).