From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3A5402F54BB; Mon, 5 May 2025 22:24:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746483889; cv=none; b=t9O0vGOygNxURQ9qOzM7bUXDEhWU4e4GpPUtbtwbJTtm7VeGYoa+BcenBtd8a3hunlbq6Tjrgd2UgVZRo6cDvUmt56Qpdu5NiRAKKlPMQSdkPVPFhcIwNj27v4usoLUzWEIVHb3/XUUPoz03JzoinvYNRgvH/420voVeDU1jps8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746483889; c=relaxed/simple; bh=qwZPm942gxOToziOlF8sQo8tPAhUDpjCMdaO2TebVFY=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=jPYCVbI6m7neHD+b504lcgOJpNFI42B+w0xF18EvOnkCI4F+nrbSk4D0i7K58o2itpCaQTtbS8jFoY4E8JeabYuZJwjvwuPPNtL52P/YxYdN3cBruQebjqqenyPrRGIzVvtzXVMv2a7V29Pqb4oQdRcUxvekUFnV+Fr1eOMY8pA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=kWBewYzp; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="kWBewYzp" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 14E3FC4CEE4; Mon, 5 May 2025 22:24:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1746483889; bh=qwZPm942gxOToziOlF8sQo8tPAhUDpjCMdaO2TebVFY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kWBewYzp5R+Lq62g2WB4HkdzZhLfzZ068V/J7yZQBdskkqjg7TDKz2MOLykQelBZ1 X+il3/mf6KAZTO6VQxWN91HUhTf1gxlyKZp7e0g//CTUCsefvtOcECbYMmNvU0/AKp yHZEnfnIMOLGEq7JACT/pzBI9U7Cr7RUjYWKHMdNnP1fS+skAfwXBsVuyJycwLsgB9 7tj0Zaj5Zbx6bClZIESfzqKwok/9bdHoj1z/BwSlS1AQf5c8qv8wk+FTjiZhvrMqgn uCvAHPo4hEBv8VpAgDQGznzUr2/XZNC8gu6FzZd/ANkcY5N9WqM0U2+WUppr3Hp1uZ 8yNIkUCCASNig== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Hans Verkuil , Mauro Carvalho Chehab , Sasha Levin , mchehab@kernel.org, ribalda@chromium.org, christophe.jaillet@wanadoo.fr, linux-media@vger.kernel.org Subject: [PATCH AUTOSEL 6.14 257/642] media: cx231xx: set device_caps for 417 Date: Mon, 5 May 2025 18:07:53 -0400 Message-Id: <20250505221419.2672473-257-sashal@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250505221419.2672473-1-sashal@kernel.org> References: <20250505221419.2672473-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.14.5 Content-Transfer-Encoding: 8bit From: Hans Verkuil [ Upstream commit a79efc44b51432490538a55b9753a721f7d3ea42 ] The video_device for the MPEG encoder did not set device_caps. Add this, otherwise the video device can't be registered (you get a WARN_ON instead). Not seen before since currently 417 support is disabled, but I found this while experimenting with it. Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/usb/cx231xx/cx231xx-417.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/media/usb/cx231xx/cx231xx-417.c b/drivers/media/usb/cx231xx/cx231xx-417.c index a4a9781328c50..06d61e52f018c 100644 --- a/drivers/media/usb/cx231xx/cx231xx-417.c +++ b/drivers/media/usb/cx231xx/cx231xx-417.c @@ -1720,6 +1720,8 @@ static void cx231xx_video_dev_init( vfd->lock = &dev->lock; vfd->release = video_device_release_empty; vfd->ctrl_handler = &dev->mpeg_ctrl_handler.hdl; + vfd->device_caps = V4L2_CAP_READWRITE | V4L2_CAP_STREAMING | + V4L2_CAP_VIDEO_CAPTURE; video_set_drvdata(vfd, dev); if (dev->tuner_type == TUNER_ABSENT) { v4l2_disable_ioctl(vfd, VIDIOC_G_FREQUENCY); -- 2.39.5