From: Greg KH <gregkh@linuxfoundation.org>
To: Daniel Wagner <dwagner@suse.de>
Cc: Jack Wang <jinpu.wang@ionos.com>,
Wang Yugui <wangyugui@e16-tech.com>,
stable@vger.kernel.org, wagi@kernel.org
Subject: Re: [6.12.y] WARNING: CPU: 0 PID: 681 at block/blk-mq-cpumap.c:90 blk_mq_map_hw_queues+0xcf/0xe0
Date: Mon, 5 May 2025 15:52:38 +0200 [thread overview]
Message-ID: <2025050555-overhung-jiffy-6b63@gregkh> (raw)
In-Reply-To: <6f78e096-cb32-4056-a65a-50c27825d0e1@flourine.local>
On Mon, May 05, 2025 at 03:40:51PM +0200, Daniel Wagner wrote:
> On Mon, May 05, 2025 at 03:28:22PM +0200, Greg KH wrote:
> > On Mon, May 05, 2025 at 01:36:52PM +0200, Jack Wang wrote:
> > > From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > >
> > > In linux-6.12.y, commit 5e8438fd7f11 ("scsi: replace blk_mq_pci_map_queues with blk_mq_map_hw_queues")
> > > was pulled in as depandency, the fix a9ae6fe1c319 ("blk-mq: create correct map for fallback case")
> > > should have just used 1452e9b470c9 ("blk-mq: introduce blk_mq_map_hw_queues")
> > > as Fixes, not the other conversion IMO.
> >
> > What "other conversion"? Sorry, I do not understand, did we take a
> > patch we shouldn't have, or did we miss a patch we should have applied?
>
> If I understand the situation correctly, the problem is that v6.14.25
> ships commit 5e8438fd7f11 ("scsi: replace blk_mq_pci_map_queues with
> blk_mq_map_hw_queues") which introduced a regression for certain virtio
> configurations. The fixup patch is:
>
> a9ae6fe1c319 ("blk-mq: create correct map for fallback case")
>
But commit a9ae6fe1c319 ("blk-mq: create correct map for fallback case")
says it fixes commit a5665c3d150c ("virtio: blk/scsi: replace
blk_mq_virtio_map_queues with blk_mq_map_hw_queues"), which is ONLY in
the 6.14 tree.
Which is why we didn't pull it into the stable tree here. Is that
commit just not marked properly? Will it cause problems if it is
backported?
thanks,
greg k-h
next prev parent reply other threads:[~2025-05-05 13:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-03 1:14 [6.12.y] WARNING: CPU: 0 PID: 681 at block/blk-mq-cpumap.c:90 blk_mq_map_hw_queues+0xcf/0xe0 Wang Yugui
2025-05-03 2:05 ` Wang Yugui
2025-05-05 9:24 ` Greg Kroah-Hartman
2025-05-05 11:36 ` Jack Wang
2025-05-05 13:28 ` Greg KH
2025-05-05 13:40 ` Daniel Wagner
2025-05-05 13:52 ` Greg KH [this message]
2025-05-05 14:05 ` Daniel Wagner
2025-05-05 14:21 ` Greg KH
2025-05-05 13:41 ` Jinpu Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025050555-overhung-jiffy-6b63@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=dwagner@suse.de \
--cc=jinpu.wang@ionos.com \
--cc=stable@vger.kernel.org \
--cc=wagi@kernel.org \
--cc=wangyugui@e16-tech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox