From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 204312116E9; Wed, 7 May 2025 18:50:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746643826; cv=none; b=eHzTcG+YDwLAoAmEHeDnvPHlCKjFHn9reIVL92tUIA+crDbBxPeHNl5TFbanYRliEaxFr/shWaZ4BpceRMhOpu1p8aVBXarASH6Kqpmk7navpnnCdykaqJFXBQunQJmDNhTpCojgjMdmO9mHJJaixCZKelLrSTgtrZfbPT13Djc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746643826; c=relaxed/simple; bh=y3xV0pgL649ZwEbO89qbFvHHIePtxU6RciwKJOl7u1Y=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=VJN1aG0BVNB9gWYfl8khAgd2JqaGiGAXmfraVun4aCuNQO2s0M5gCd3Om3+YWS8OoQU05MUTTiYaeJuhVFY6gQz9AcoZMhcxRlTJdo/NrA3L57575ZyHVmkKLDeuyDT1eB5eBWaEt0AlOOZaJ/0fO609ukRTY+rheXxfXGhgqA4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=g09IZL3j; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="g09IZL3j" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9E3A8C4CEEB; Wed, 7 May 2025 18:50:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1746643826; bh=y3xV0pgL649ZwEbO89qbFvHHIePtxU6RciwKJOl7u1Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=g09IZL3jgraUUBg+/VlBAPIBb3E9QCGU7JaXhLapgCoqgGvz7idZJ/sNGeOYU10Ua IVk/lZ1qrZnHBSm3E9wHW+iwdN4ow6K1ezsenlJcaxfAQIu8+12YHi2YP/TaD6Mxzg Ka7GwOyyhVRKLWEg2H3+wV/1YJ7CuYBX1bCbIkUI= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Benjamin Marzinski , Mikulas Patocka Subject: [PATCH 6.14 030/183] dm: always update the array size in realloc_argv on success Date: Wed, 7 May 2025 20:37:55 +0200 Message-ID: <20250507183825.912392976@linuxfoundation.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250507183824.682671926@linuxfoundation.org> References: <20250507183824.682671926@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Benjamin Marzinski commit 5a2a6c428190f945c5cbf5791f72dbea83e97f66 upstream. realloc_argv() was only updating the array size if it was called with old_argv already allocated. The first time it was called to create an argv array, it would allocate the array but return the array size as zero. dm_split_args() would think that it couldn't store any arguments in the array and would call realloc_argv() again, causing it to reallocate the initial slots (this time using GPF_KERNEL) and finally return a size. Aside from being wasteful, this could cause deadlocks on targets that need to process messages without starting new IO. Instead, realloc_argv should always update the allocated array size on success. Fixes: a0651926553c ("dm table: don't copy from a NULL pointer in realloc_argv()") Cc: stable@vger.kernel.org Signed-off-by: Benjamin Marzinski Signed-off-by: Mikulas Patocka Signed-off-by: Greg Kroah-Hartman --- drivers/md/dm-table.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) --- a/drivers/md/dm-table.c +++ b/drivers/md/dm-table.c @@ -523,9 +523,10 @@ static char **realloc_argv(unsigned int gfp = GFP_NOIO; } argv = kmalloc_array(new_size, sizeof(*argv), gfp); - if (argv && old_argv) { - memcpy(argv, old_argv, *size * sizeof(*argv)); + if (argv) { *size = new_size; + if (old_argv) + memcpy(argv, old_argv, *size * sizeof(*argv)); } kfree(old_argv);