From: Sasha Levin <sashal@kernel.org>
To: stable@vger.kernel.org, wqu@suse.com
Cc: Sasha Levin <sashal@kernel.org>
Subject: Re: [PATCH] btrfs: always fallback to buffered write if the inode requires checksum
Date: Thu, 8 May 2025 21:52:17 -0400 [thread overview]
Message-ID: <20250508141536-9e8c55fefb992cad@stable.kernel.org> (raw)
In-Reply-To: <dcffa5400745663641e58a261e8dbccbb194b468.1746666392.git.wqu@suse.com>
[ Sasha's backport helper bot ]
Hi,
Summary of potential issues:
❌ Build failures detected
The upstream commit SHA1 provided is correct: 968f19c5b1b7d5595423b0ac0020cc18dfed8cb5
Note: The patch differs from the upstream commit:
---
1: 968f19c5b1b7d < -: ------------- btrfs: always fallback to buffered write if the inode requires checksum
-: ------------- > 1: aeaee199900ee Linux 6.14.5
---
Results of testing on various branches:
| Branch | Patch Apply | Build Test |
|---------------------------|-------------|------------|
| stable/linux-6.14.y | Success | Success |
| stable/linux-6.12.y | Success | Success |
| stable/linux-6.6.y | Success | Success |
| stable/linux-6.1.y | Success | Failed |
| stable/linux-5.15.y | Success | Failed |
| stable/linux-5.10.y | Success | Success |
| stable/linux-5.4.y | Success | Success |
Build Errors:
Build error for stable/linux-6.1.y:
fs/btrfs/file.c: In function 'btrfs_direct_write':
fs/btrfs/file.c:1522:36: error: passing argument 1 of 'btrfs_inode_unlock' from incompatible pointer type [-Wincompatible-pointer-types]
1522 | btrfs_inode_unlock(BTRFS_I(inode), ilock_flags);
| ^~~~~~~~~~~~~~
| |
| struct btrfs_inode *
In file included from fs/btrfs/file.c:20:
fs/btrfs/ctree.h:3487:39: note: expected 'struct inode *' but argument is of type 'struct btrfs_inode *'
3487 | void btrfs_inode_unlock(struct inode *inode, unsigned int ilock_flags);
| ~~~~~~~~~~~~~~^~~~~
make[3]: *** [scripts/Makefile.build:250: fs/btrfs/file.o] Error 1
make[3]: Target 'fs/btrfs/' not remade because of errors.
make[2]: *** [scripts/Makefile.build:503: fs/btrfs] Error 2
make[2]: Target 'fs/' not remade because of errors.
make[1]: *** [scripts/Makefile.build:503: fs] Error 2
make[1]: Target './' not remade because of errors.
make: *** [Makefile:2013: .] Error 2
make: Target '__all' not remade because of errors.
Build error for stable/linux-5.15.y:
fs/btrfs/file.c: In function 'btrfs_direct_write':
fs/btrfs/file.c:1979:36: error: passing argument 1 of 'btrfs_inode_unlock' from incompatible pointer type [-Werror=incompatible-pointer-types]
1979 | btrfs_inode_unlock(BTRFS_I(inode), ilock_flags);
| ^~~~~~~~~~~~~~
| |
| struct btrfs_inode *
In file included from fs/btrfs/file.c:20:
fs/btrfs/ctree.h:3282:39: note: expected 'struct inode *' but argument is of type 'struct btrfs_inode *'
3282 | void btrfs_inode_unlock(struct inode *inode, unsigned int ilock_flags);
| ~~~~~~~~~~~~~~^~~~~
cc1: some warnings being treated as errors
make[2]: *** [scripts/Makefile.build:289: fs/btrfs/file.o] Error 1
make[2]: Target '__build' not remade because of errors.
make[1]: *** [scripts/Makefile.build:552: fs/btrfs] Error 2
make[1]: Target '__build' not remade because of errors.
make: *** [Makefile:1914: fs] Error 2
make: Target '__all' not remade because of errors.
next prev parent reply other threads:[~2025-05-09 1:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-08 1:09 [PATCH 6.6.y] btrfs: always fallback to buffered write if the inode requires checksum Qu Wenruo
2025-05-08 1:09 ` [PATCH] " Qu Wenruo
2025-05-08 5:30 ` Greg KH
2025-05-08 7:05 ` Qu Wenruo
2025-05-09 1:52 ` Sasha Levin [this message]
2025-05-09 1:52 ` [PATCH 6.6.y] " Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250508141536-9e8c55fefb992cad@stable.kernel.org \
--to=sashal@kernel.org \
--cc=stable@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox