From: Sasha Levin <sashal@kernel.org>
To: stable@vger.kernel.org, jianqi.ren.cn@windriver.com
Cc: Sasha Levin <sashal@kernel.org>
Subject: Re: [PATCH 6.1.y] selinux: avoid dereference of garbage after mount failure
Date: Mon, 12 May 2025 17:52:23 -0400 [thread overview]
Message-ID: <20250512161804-4a1e0992fbba3fe6@stable.kernel.org> (raw)
In-Reply-To: <20250512014400.3326099-1-jianqi.ren.cn@windriver.com>
[ Sasha's backport helper bot ]
Hi,
Summary of potential issues:
❌ Build failures detected
The upstream commit SHA1 provided is correct: 37801a36b4d68892ce807264f784d818f8d0d39b
WARNING: Author mismatch between patch and upstream commit:
Backport author: <jianqi.ren.cn@windriver.com>
Commit author: Christian Göttsche<cgzones@googlemail.com>
Status in newer kernel trees:
6.14.y | Present (exact SHA1)
6.12.y | Present (exact SHA1)
6.6.y | Present (different SHA1: 477ed6789eb9)
Note: The patch differs from the upstream commit:
---
1: 37801a36b4d68 ! 1: 31f99abbcce21 selinux: avoid dereference of garbage after mount failure
@@ Metadata
## Commit message ##
selinux: avoid dereference of garbage after mount failure
+ commit 37801a36b4d68892ce807264f784d818f8d0d39b upstream.
+
In case kern_mount() fails and returns an error pointer return in the
error branch instead of continuing and dereferencing the error pointer.
@@ Commit message
Fixes: 0619f0f5e36f ("selinux: wrap selinuxfs state")
Signed-off-by: Christian Göttsche <cgzones@googlemail.com>
Signed-off-by: Paul Moore <paul@paul-moore.com>
+ Signed-off-by: Jianqi Ren <jianqi.ren.cn@windriver.com>
+ Signed-off-by: He Zhe <zhe.he@windriver.com>
## security/selinux/selinuxfs.c ##
@@ security/selinux/selinuxfs.c: static struct file_system_type sel_fs_type = {
---
Results of testing on various branches:
| Branch | Patch Apply | Build Test |
|---------------------------|-------------|------------|
| stable/linux-6.1.y | Success | Failed |
Build Errors:
Build error for stable/linux-6.1.y:
security/selinux/selinuxfs.c: In function 'exit_sel_fs':
security/selinux/selinuxfs.c:2261:22: error: 'selinuxfs_mount' undeclared (first use in this function)
2261 | kern_unmount(selinuxfs_mount);
| ^~~~~~~~~~~~~~~
security/selinux/selinuxfs.c:2261:22: note: each undeclared identifier is reported only once for each function it appears in
make[3]: *** [scripts/Makefile.build:250: security/selinux/selinuxfs.o] Error 1
make[3]: Target 'security/selinux/' not remade because of errors.
make[2]: *** [scripts/Makefile.build:503: security/selinux] Error 2
make[2]: Target 'security/' not remade because of errors.
make[1]: *** [scripts/Makefile.build:503: security] Error 2
make[1]: Target './' not remade because of errors.
make: *** [Makefile:2013: .] Error 2
make: Target '__all' not remade because of errors.
next prev parent reply other threads:[~2025-05-12 21:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-12 1:44 [PATCH 6.1.y] selinux: avoid dereference of garbage after mount failure jianqi.ren.cn
2025-05-12 21:52 ` Sasha Levin [this message]
2025-05-20 11:18 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250512161804-4a1e0992fbba3fe6@stable.kernel.org \
--to=sashal@kernel.org \
--cc=jianqi.ren.cn@windriver.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox