From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1CF73254879; Mon, 12 May 2025 17:53:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747072384; cv=none; b=Xth9IiKbDUV88IC0eVqtlDlk8YDMcH5aqFciiJHafWtuFaOefWg2840279FI1s9crDPnHAkNTlLaVv1lZUz1ayfJnwo7cFUsbsp+6RlFUpHbP1hO/xJJbOS+c+fBDG5C6INtu3QWq8SFAoMnR65kw/OVFjf75sKuIYTA44bftQ8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747072384; c=relaxed/simple; bh=ukp6rZepbQQA7qgzDPak04yxe4hUXwumj7tLoeKYNBY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=iWLBGpyFh/wxkQZQKu09igwgDbjRzgTyZAMra+krTGQBUWacg9fQdzEbH6hvOgFTLNb60NmeZXngq/IpxMaCArNWcztUcGT2GrK/grO0jcFX0jR2L/kNaeH/C4HkFjlzMxOWEs46td3rsGfURmrsU7WC1zi9Eqvx1TCWhKNFAAw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=zZMXBn56; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="zZMXBn56" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9878FC4CEE7; Mon, 12 May 2025 17:53:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1747072384; bh=ukp6rZepbQQA7qgzDPak04yxe4hUXwumj7tLoeKYNBY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=zZMXBn56Nxjdw8LV5uhYoQlHcNwsUgSODpsbi/+utGnB5by56Zua/cobnZ4blBtVF fGiWexUWdkxuq3fDmbruwPa9w1k51aJLxQ80wuXpqjmMpG/1ojiNFS4zCzgyBoY3uu YUyLngE0v1pvmVxZFX9jVYavMG5WRvhmgENad5ME= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Marc Kleine-Budde Subject: [PATCH 6.1 04/92] can: mcp251xfd: mcp251xfd_remove(): fix order of unregistration calls Date: Mon, 12 May 2025 19:44:39 +0200 Message-ID: <20250512172023.314153688@linuxfoundation.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250512172023.126467649@linuxfoundation.org> References: <20250512172023.126467649@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Marc Kleine-Budde commit 84f5eb833f53ae192baed4cfb8d9eaab43481fc9 upstream. If a driver is removed, the driver framework invokes the driver's remove callback. A CAN driver's remove function calls unregister_candev(), which calls net_device_ops::ndo_stop further down in the call stack for interfaces which are in the "up" state. With the mcp251xfd driver the removal of the module causes the following warning: | WARNING: CPU: 0 PID: 352 at net/core/dev.c:7342 __netif_napi_del_locked+0xc8/0xd8 as can_rx_offload_del() deletes the NAPI, while it is still active, because the interface is still up. To fix the warning, first unregister the network interface, which calls net_device_ops::ndo_stop, which disables the NAPI, and then call can_rx_offload_del(). Fixes: 55e5b97f003e ("can: mcp25xxfd: add driver for Microchip MCP25xxFD SPI CAN") Cc: stable@vger.kernel.org Link: https://patch.msgid.link/20250502-can-rx-offload-del-v1-1-59a9b131589d@pengutronix.de Signed-off-by: Marc Kleine-Budde Signed-off-by: Greg Kroah-Hartman --- drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c +++ b/drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c @@ -2179,8 +2179,8 @@ static void mcp251xfd_remove(struct spi_ struct mcp251xfd_priv *priv = spi_get_drvdata(spi); struct net_device *ndev = priv->ndev; - can_rx_offload_del(&priv->offload); mcp251xfd_unregister(priv); + can_rx_offload_del(&priv->offload); spi->max_speed_hz = priv->spi_max_speed_hz_orig; free_candev(ndev); }